Date: Sun, 10 Mar 2024 09:43:14 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 021fcd36af22 - main - games/coffeebreak: Move man pages to share/man Message-ID: <CAFDf7UKq-onz-dbR=pm03Ji1FHb-u81Cidohi-be-EnVvYsGUQ@mail.gmail.com> In-Reply-To: <Ze16dMKKJxs9IN3t@FreeBSD.org> References: <202403090831.4298VJo6024021@gitrepo.freebsd.org> <Ze16dMKKJxs9IN3t@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello danfe!
Good point.
The problem here is that I can't use MANDIR in MAKE_ARGS because
Makefile have $(DESTDIR) defined in MANDIR var.
MANDIR =3D $(DESTDIR)$(PREFIX)/man
Also, SED is needed anyway to fix hardcoded "/usr/local" to PREFIX.
Any sugestions to simplify this?
Thanks,
Alexey Dokuchaev <danfe@freebsd.org> escreveu (domingo, 10/03/2024 =C3=A0(s=
) 09:16):
>
> On Sat, Mar 09, 2024 at 08:31:19AM +0000, Nuno Teixeira wrote:
> > commit 021fcd36af22585a4bcf6e71ccb9a7d0f6ed204a
> >
> > games/coffeebreak: Move man pages to share/man
> > ...
> > +
> > +post-patch:
> > + ${REINPLACE_CMD} 's|/usr/local|${PREFIX}|g' ${WRKSRC}/Makefile
> >
> > .include <bsd.port.mk>
> > ...
> > +--- Makefile.orig 2024-03-09 06:57:33 UTC
> > ++++ Makefile
> > +@@ -27,7 +27,7 @@ BINDIR =3D $(DESTDIR)$(PREFIX)/bin
> > +
> > + PREFIX =3D /usr/local
> > + BINDIR =3D $(DESTDIR)$(PREFIX)/bin
> > +-MANDIR =3D $(DESTDIR)$(PREFIX)/man
> > ++MANDIR =3D $(DESTDIR)$(PREFIX)/share/man
>
> We typically don't patch makefiles, esp. twice (sed+patch) when we have
> MAKE_ARGS for that matter. Grepping "git log" output for MAKE_ARGS can
> yield plenty of examples.
>
> ./danfe
--=20
Nuno Teixeira
FreeBSD Committer (ports)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKq-onz-dbR=pm03Ji1FHb-u81Cidohi-be-EnVvYsGUQ>