Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jan 2011 18:14:59 +0000 (UTC)
From:      "George V. Neville-Neil" <gnn@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r217113 - head/sys/netinet
Message-ID:  <201101071814.p07IExJm060986@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gnn
Date: Fri Jan  7 18:14:58 2011
New Revision: 217113
URL: http://svn.freebsd.org/changeset/base/217113

Log:
  Adjust ARP hold queue locking.
  
  Submitted by:	Rozhuk Ivan, jhb
  MFC after:	2 weeks

Modified:
  head/sys/netinet/if_ether.c

Modified: head/sys/netinet/if_ether.c
==============================================================================
--- head/sys/netinet/if_ether.c	Fri Jan  7 16:54:29 2011	(r217112)
+++ head/sys/netinet/if_ether.c	Fri Jan  7 18:14:58 2011	(r217113)
@@ -731,6 +731,9 @@ match:
 		if (la->la_hold != NULL) {
 			struct mbuf *m_hold, *m_hold_next;
 
+			m_hold = la->la_hold;
+			la->la_hold = NULL;
+			la->la_numheld = 0;
 			memcpy(&sa, L3_ADDR(la), sizeof(sa));
 			LLE_WUNLOCK(la);
 			for (m_hold = la->la_hold, la->la_hold = NULL;
@@ -741,8 +744,6 @@ match:
 			}
 		} else
 			LLE_WUNLOCK(la);
-		la->la_hold = NULL;
-		la->la_numheld = 0;
 	} /* end of FIB loop */
 reply:
 	if (op != ARPOP_REQUEST)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101071814.p07IExJm060986>