Date: Wed, 19 Oct 2005 10:46:29 -0700 From: Sam Leffler <sam@errno.com> To: Niki Denev <nike_d@cytexbg.com> Cc: freebsd-current@freebsd.org Subject: Re: ath not setting media type? [SOLVED : devd is to blame] Message-ID: <43568675.4020409@errno.com> In-Reply-To: <200510191958.27827.nike_d@cytexbg.com> References: <200510181233.47769.nike_d@cytexbg.com> <43554809.4060900@errno.com> <4356129F.90602@cytexbg.com> <200510191958.27827.nike_d@cytexbg.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Niki Denev wrote:
> I think i found the problem, and it's in devd.
>
> The problem affects only the media/link status notify events because
> there the interface name is supplied in the variable "subsystem",
> which fails to be assigned properly.
>
> I'm not C++ expert but it looks that the duplicated declaration of the
> variable "value" is the problem.
> I wonder why compiler doesn't complain about this... but i may be wrong,
> because i don't know anyting about c++ :)
>
> this patch fixed it for me :
>
> ------------------------------------------------------------------------------------------------
> --- devd.cc.orig Wed Oct 19 19:50:28 2005
> +++ devd.cc Wed Oct 19 19:53:29 2005
> @@ -233,7 +233,7 @@
> // to subsystem if none exists.
> value = c.get_variable("device-name");
> if (value.length() == 0)
> - string value = c.get_variable("subsystem");
> + value = c.get_variable("subsystem");
> if (Dflag)
> fprintf(stderr, "Testing media type of %s against 0x%x\n",
> value.c_str(), _type);
> ------------------------------------------------------------------------------------------------
>
> [http://www.totalterror.net/freebsd/devd.patch]
>
Thank you; this'll get committed shortly.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43568675.4020409>