Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Jul 2022 18:47:15 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 29534af72577 - stable/13 - Adjust ng_{name,ID}_rehash() definitions to avoid clang 15 warnings
Message-ID:  <202207291847.26TIlFBC023865@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=29534af72577bd75ed3fcba96d3cf5c5786dc7d7

commit 29534af72577bd75ed3fcba96d3cf5c5786dc7d7
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-25 11:04:29 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-29 18:28:08 +0000

    Adjust ng_{name,ID}_rehash() definitions to avoid clang 15 warnings
    
    With clang 15, the following -Werror warnings are produced:
    
        sys/netgraph/ng_base.c:981:15: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
        ng_name_rehash()
                      ^
                       void
        sys/netgraph/ng_base.c:1012:13: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
        ng_ID_rehash()
                    ^
                     void
    
    This is because ng_name_rehash() and ng_ID_rehash() are declared with
    (void) argument lists, but defined with empty argument lists. Make the
    definitions match the declarations.
    
    MFC after:      3 days
    
    (cherry picked from commit dba7f4aa0909d8c31a0ca0ad0d1208fabfaa9352)
---
 sys/netgraph/ng_base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netgraph/ng_base.c b/sys/netgraph/ng_base.c
index ddf7de410212..1b8b26f38f34 100644
--- a/sys/netgraph/ng_base.c
+++ b/sys/netgraph/ng_base.c
@@ -978,7 +978,7 @@ ng_unname(node_p node)
  * Allocate a bigger name hash.
  */
 static void
-ng_name_rehash()
+ng_name_rehash(void)
 {
 	struct nodehash *new;
 	uint32_t hash;
@@ -1009,7 +1009,7 @@ ng_name_rehash()
  * Allocate a bigger ID hash.
  */
 static void
-ng_ID_rehash()
+ng_ID_rehash(void)
 {
 	struct nodehash *new;
 	uint32_t hash;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207291847.26TIlFBC023865>