Date: Fri, 17 Dec 2004 11:20:54 +0000 From: Nik Clayton <nik@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile Message-ID: <20041217112053.GK17158@clan.nothing-going-on.org> In-Reply-To: <200412161955.iBGJtvIO060191@repoman.freebsd.org> References: <200412161955.iBGJtvIO060191@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--08ATZu8fEq0x2T3M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ruslan, On Thu, Dec 16, 2004 at 07:55:57PM +0000, Ruslan Ermilov wrote: > Previous revision didn't fix all cases. For example, > testing for variables that are always defined (e.g., > "make -V CC") would still print a false warning. Fix > this by only passing a submake the MAKEOBJDIRPREFIX=3D* > argument if it was present. As a result, we loose > the check for -DMAKEOBJDIRPREFIX, or an esoteric > "MAKEOBJDIRPREFIX =3D foo" (with embedded spaces), but > these are unorthodox enough to not care about them. > =20 > The make(1) bug mentioned in the previous revision > was just fixed in make/main.c,v 1.109. Do you have test cases for these issues? They should be added to=20 tools/regression/usr.bin/make. N --=20 FreeBSD: The Power to Serve http://www.freebsd.org/ (__) FreeBSD Documentation Project http://www.freebsd.org/docproj/ \\\'',) \/ \= ^ --- 15B8 3FFC DDB4 34B0 AA5F 94B7 93A8 0764 2C37 E375 --- .\._/= _) --08ATZu8fEq0x2T3M Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwsEVk6gHZCw343URAqjNAJsFEJphI0Rt7Z/QLsOiWwmcY8U+ugCfZEZH DfNUKbRRnUP18+vq7NjsAS0= =ZD+A -----END PGP SIGNATURE----- --08ATZu8fEq0x2T3M--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041217112053.GK17158>