Date: Wed, 12 Jan 2011 16:21:30 -0500 From: John Baldwin <jhb@freebsd.org> To: Matthew D Fleming <mdf@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217330 - head/sys/x86/x86 Message-ID: <201101121621.30371.jhb@freebsd.org> In-Reply-To: <201101122108.p0CL8o3Q012038@svn.freebsd.org> References: <201101122108.p0CL8o3Q012038@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 12, 2011 4:08:50 pm Matthew D Fleming wrote: > Author: mdf > Date: Wed Jan 12 21:08:49 2011 > New Revision: 217330 > URL: http://svn.freebsd.org/changeset/base/217330 > > Log: > Fix a brain fart. Since this file is shared between i386 and amd64, a > bus_size_t may be 32 or 64 bits. Change the bounce_zone alignment field > to explicitly be 32 bits, as I can't really imagine a DMA device that > needs anything close to 2GB alignment of data. Hmm, we do have devices with 4GB boundaries though. I think I'd prefer it if you instead if you did this: #if defined(amd64) || defined(PAE) #define SYSCTL_ADD_BUS_SIZE_T SYSCTL_ADD_UQUAD #else #define SYSCTL_ADD_BUS_SIZE_T SYSCTL_ADD_UINT #endif and then just used SYSCTL_ADD_BUS_SIZE_T() in the code so we could let the members in the bounce zone retain the same types passed to bus_dma_tag_create(). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101121621.30371.jhb>