Date: Wed, 30 Jan 2019 16:38:08 +0100 From: Marius Strobl <marius@freebsd.org> To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343578 - in head/sys: dev/e1000 dev/ixgbe dev/ixl dev/vmware/vmxnet3 net Message-ID: <20190130153808.GE12067@alchemy.franken.de> In-Reply-To: <201901301447.x0UEliQq013590@pdx.rh.CN85.dnsmgr.net> References: <201901301321.x0UDLRGP027749@repo.freebsd.org> <201901301447.x0UEliQq013590@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 30, 2019 at 06:47:44AM -0800, Rodney W. Grimes wrote: > > Author: marius > > Date: Wed Jan 30 13:21:26 2019 > > New Revision: 343578 > > URL: https://svnweb.freebsd.org/changeset/base/343578 > > > > Log: > > - Stop iflib(4) from leaking MSI messages on detachment by calling > > bus_teardown_intr(9) before pci_release_msi(9). > > - Ensure that iflib(4) and associated drivers pass correct RIDs to > > bus_release_resource(9) by obtaining the RIDs via rman_get_rid(9) > > on the corresponding resources instead of using the RIDs initially > > passed to bus_alloc_resource_any(9) as the latter function may > > change those RIDs. Solely em(4) for the ioport resource (but not > > others) and bnxt(4) were using the correct RIDs by caching the ones > > returned by bus_alloc_resource_any(9). > > - Change the logic of iflib_msix_init() around to only map the MSI-X > > BAR if MSI-X is actually supported, i. e. pci_msix_count(9) returns > > > 0. Otherwise the "Unable to map MSIX table " message triggers for > > devices that simply don't support MSI-X and the user may think that > > something is wrong while in fact everything works as expected. > > - Put some (mostly redundant) debug messages emitted by iflib(4) > > and em(4) during attachment under bootverbose. The non-verbose > > output of em(4) seen during attachment now is close to the one > > prior to the conversion to iflib(4). > > - Replace various variants of spelling "MSI-X" (several in messages) > > with "MSI-X" as used in the PCI specifications. > > - Remove some trailing whitespace from messages emitted by iflib(4) > > and change them to consistently start with uppercase. > > - Remove some obsolete comments about releasing interrupts from > > drivers and correct a few others. > > > > Reviewed by: erj, Jacob Keller, shurd > > Differential Revision: https://reviews.freebsd.org/D18980 > > MFC intentions? > I am sure you mean to, just not sure how soon. Probably after the 3 days minimum so we finally can start with trying to wrap up an iflib EN for 12.0. > Does this effect any of the PR's open against em(4)/iflib(9)? The above revision addresses the "Unable to map MSIX table " part of PR 234766, but not its core problem of the interface wedging. The previous switch to using bus_dma(9) and associated fixes may or may not solve the remainder of PR 234766 and some of the other PRs filed against em(4) in 12.0. PR 228827 is about device attachment with iflib(4) but misses details. Several problems with that attachment (apart from the above, e. g. also interrupt method fallback) have been fixed since that PR was filed, though. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190130153808.GE12067>