Date: Thu, 16 Feb 2023 08:57:38 +0100 From: Gordon Bergling <gbe@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Gordon Bergling <gbe@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: <Y%2B3h8n6tDAdmXWpj@lion.ttyv0.de> In-Reply-To: <CANCZdfpMa1HzBBYrZLQBSn-Z11gE5=Gn5KTm%2B2tCzgJ3=S6kQw@mail.gmail.com> References: <Y%2BjFd1MGxFAth1xL@lion.ttyv0.de> <CANCZdfp_CD81r1E0S67Y6NA82xe3OcWazDm308WEn7_MkUzNDA@mail.gmail.com> <CANCZdfpMa1HzBBYrZLQBSn-Z11gE5=Gn5KTm%2B2tCzgJ3=S6kQw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--7oN4/LC7dxEXkojl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Warner,
On Wed, Feb 15, 2023 at 10:07:08AM -0700, Warner Losh wrote:
> On Sun, Feb 12, 2023, 3:18 PM Warner Losh <imp@bsdimp.com> wrote:
> > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling <gbe@freebsd.org> wrote:
> >
> >> Hi,
> >>
> >> I am currently seeing a build breakage when building -CURRENT with
> >> WITH_BEARSSL=3D1.
> >>
> >> The error is the following
> >>
> >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109:
> >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.a=
sc 2>
> >> /dev/null" returned non-zero status
> >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro=
r:
> >> a function declaration without a prototype is deprecat ed in all vers=
ions
> >> of C [-Werror,-Wstrict-prototypes]
> >> br_rsa_i62_keygen_get()
> >> ^
> >> void
> >> 1 error generated.
> >> --- rsa_i62_keygen.pico ---
> >>
> >>
> >> When disabling BEARSSL in the src.conf the build succeeds as usual.
> >>
> >> Has anyone also seen this build error. Sources are very recent and the
> >> src.conf is the following:
> >>
> >> WITH_EXTRA_TCP_STACKS=3D1
> >> #WITH_BEARSSL=3D1
> >> WITH_PIE=3D1
> >> WITH_RETPOLINE=3D1
> >> WITH_INIT_ALL_ZERO=3D1
> >> WITH_OPENSSL_KTLS=3D1
> >> WITHOUT_CLEAN=3D1
> >>
> >> Any help is very appreciated.
> >>
> >>
> > What does the following do for you? It's a cut and pasted patch, but it
> > should be clear enough what to do if the mailer mangles it.
> >
> > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc
> > index dd0e242c8ef0..2af4864d8441 100644
> > --- a/lib/libbearssl/Makefile.inc
> > +++ b/lib/libbearssl/Makefile.inc
> > @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
> > BEARSSL_SRC=3D ${BEARSSL}/src
> >
> > CFLAGS+=3D -I${BEARSSL}/inc
> > -
> > +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}
> >
>=20
> I went ahead and committed this. Please let me know if the problem persis=
ts.
Sorry for the late reply. I just tried a fresh build and it still fails with
[..]/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function
declaration without a prototype is deprecated in all versions of C [-Werror=
,-Wstrict-prototypes]
br_rsa_i62_keygen_get()
Did you see any other possibilty to fix this?
--Gordon
--7oN4/LC7dxEXkojl
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPt4fFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx
QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP
09zJjQf+MSMD8j40Nn6hGmgxwuNGOpo9er6v0pirxZw1DUHNs++ysKrOTHeysEyw
nSYsXI5cVbgvGVUixuS77vzF44vZXVXLXgmaTSotscjVCrf1BKeL4RMBnmB7RxgW
rdTt6EhwSC3tJo1BWOUrmff5C1Nauz2JN98cizFEMMJWKO9aYV8peWMc05eK4xL5
+5LRSTWenvrcoep0zevjHQYNKl8MoWP79Vv+2R5l+fEDxUOSOLAJwWrCQ3LBMHp2
POIlHDNF39xt2mXlHHZkkxM6cEtl1TDDUkej+es8/gEVyWKBmZV+LKTmUV0SfKWY
9EK+20i562ac3f61JhqH0uWuGQWngg==
=MFqY
-----END PGP SIGNATURE-----
--7oN4/LC7dxEXkojl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y%2B3h8n6tDAdmXWpj>