Date: Thu, 2 Oct 2008 18:10:46 +0200 From: John Hay <jhay@meraka.org.za> To: Ed Schouten <ed@80386.nl> Cc: cvs-src@FreeBSD.org, Sam Leffler <sam@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c Message-ID: <20081002161046.GA5678@zibbi.meraka.csir.co.za> In-Reply-To: <20081002122511.GW16837@hoeg.nl> References: <200809291627.m8TGRaat081340@repoman.freebsd.org> <20081002122511.GW16837@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 02, 2008 at 02:25:11PM +0200, Ed Schouten wrote: > Hello Sam, > > * Sam Leffler <sam@FreeBSD.org> wrote: > > sam 2008-09-29 16:27:32 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/ifconfig ifconfig.c > > Log: > > SVN rev 183466 on 2008-09-29 16:27:32Z by sam > > > > Distinguish between cmd/parameters used for clone operations and > > all others. Use this to disambiguate cmd line arguments that can > > be either clone params or regular parameters so, in particular, > > "bssid" again works as a regular parameter. > > > > While here leverage the above to improve the logic for flushing > > clone operations on the first !clone cmd line parameter. > > > > Reviewed by: jhay > > Is it possible that this commit broke `ifconfig foo vlan bar vlandev baz'? > I just had to revert to an ifconfig, probably from September 22, to make > my system work properly again. And if you try with "ifconfig foo create vlan bar vlandev baz"? I have only tried it with the create keyword added and the clone stuff in /etc/network.subr also use it like that, if I read the code correctly. I think if it previously worked, it was by accident. :-/ If we need it to work, maybe one can test for vlan in main() whith the test for create or plumb? John -- John Hay -- John.Hay@meraka.csir.co.za / jhay@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081002161046.GA5678>