Date: Fri, 6 Oct 2000 07:48:32 +0200 From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de> To: Alfred Perlstein <bright@wintelcom.net> Cc: Kris Kennaway <kris@citusc.usc.edu>, Brian Somers <brian@Awfulhak.org>, Ruslan Ermilov <ru@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/finger finger.c Message-ID: <20001006074832.A9078@curry.mchp.siemens.de> In-Reply-To: <20001005142209.G27736@fw.wintelcom.net>; from bright@wintelcom.net on Thu, Oct 05, 2000 at 02:22:09PM -0700 References: <ru@FreeBSD.org> <200010051715.e95HFVn34590@hak.lan.Awfulhak.org> <20001005135833.A87853@citusc17.usc.edu> <20001005142209.G27736@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 05-Oct-2000 at 14:22:09 -0700, Alfred Perlstein wrote: > * Kris Kennaway <kris@citusc.usc.edu> [001005 13:58] wrote: > > On Thu, Oct 05, 2000 at 06:15:31PM +0100, Brian Somers wrote: > > > > ru 2000/10/05 08:56:13 PDT > > > > > > > > Modified files: > > > > usr.bin/finger finger.c > > > > Log: > > > > Do not allow `finger -m /somefile' as well. > > > > > > > > Revision Changes Path > > > > 1.21 +4 -4 src/usr.bin/finger/finger.c > > > > > > Errum, thanks. Can you mfc too ? > > > > You know, perhaps after two security holes we should just > > back this darn thing out until someone can review it? > > I think a good policy about this is to: > > 1) look at the feature and patch > 2) think about it really hard > 3) realize how f*cking useless and dangerous it is > 4) tell the submitter "no, sorry but i can't possibly put this in!" > 5) sit back and have a beer to congratulate yourself after not > introducing yet another security issue. > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=bin%2F11997 The patch described in the PR mentioned above is NOT useless. Maybe for you since you either got /var/spool/samba and /var/spool/lpd each on different 8GB filesystems or because all of your 1200 dpi color printers are currently out for repair. Of course, a patch can contain security holes -- especially if the submitter mentiones it in the text and is explicitly asking for reviewing it. I wouldn't judge things useless only because _I_ can't use it... -Andre To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001006074832.A9078>