Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Dec 2019 22:41:53 +0000 (UTC)
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r355405 - head/sys/netinet
Message-ID:  <201912042241.xB4MfrFY059723@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: glebius
Date: Wed Dec  4 22:41:52 2019
New Revision: 355405
URL: https://svnweb.freebsd.org/changeset/base/355405

Log:
  Fix regression from r354484.  Don't leak pcb lock if cr_canseeinpcb()
  returns non-zero.
  
  PR:		242415

Modified:
  head/sys/netinet/tcp_subr.c

Modified: head/sys/netinet/tcp_subr.c
==============================================================================
--- head/sys/netinet/tcp_subr.c	Wed Dec  4 21:26:03 2019	(r355404)
+++ head/sys/netinet/tcp_subr.c	Wed Dec  4 22:41:52 2019	(r355405)
@@ -2204,9 +2204,11 @@ tcp_pcblist(SYSCTL_HANDLER_ARGS)
 				error = SYSCTL_OUT(req, &xt, sizeof xt);
 				if (error)
 					break;
+				else
+					continue;
 			}
-		} else
-			INP_RUNLOCK(inp);
+		}
+		INP_RUNLOCK(inp);
 	}
 	NET_EPOCH_EXIT(et);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912042241.xB4MfrFY059723>