Date: Tue, 20 Apr 2021 15:54:50 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 043e196d694c - 2021Q2 - Add the prepare-commit-msg hook to the repository. Message-ID: <20210420135450.ahbofrjlolqf5ivy@aching.in.mat.cc> In-Reply-To: <lf9d-xfbs-wny@FreeBSD.org> References: <202104201151.13KBpDlw022416__12188.0763372005$1618919484$gmane$org@gitrepo.freebsd.org> <lf9d-xfbs-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5zydvrs3eyercxdo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 20, 2021 at 03:20:39PM +0200, Jan Beich wrote: > Mathieu Arnold <mat@FreeBSD.org> writes: >=20 > > +# MFH: <Ports tree branch name. Request approval for merge.> >=20 > Why bother after https://svnweb.freebsd.org/changeset/ports/556626 ? The MFH field always was there to note intent, not to get approval. > > +# Relnotes: <Set to 'yes' for mention in release notes.> >=20 > "yes" doesn't apply to ports/. Also, some ports/ committers already use > "Relnotes:" to link to upstream changelog. >=20 > > +# Pull Request: <https://github.com/freebsd/<repo>/pull/###>; >=20 > Looks too GitHub-specific and doesn't allow auto-close by commit. The script comes from the src tree: https://cgit.freebsd.org/src/tree/tools/tools/git/hooks/prepare-commit-msg I only removed the `MFC after` that we do not use in the ports tree. I don't see why Relnotes or Pull Request cannot be used here too. --=20 Mathieu Arnold --5zydvrs3eyercxdo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmB+3SZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKx4xAAiG7gZAP6P6ZqA3AkiXAFebL74112H3OllJjjgx+SqEhyeRupjnzGsgrb 6jEtLnRKOPbMQ8PAUWJ0js2GAHKZ5Wl48wzctLq8k0YMe6ZqB3A4EZ8kI5myyKNE 7neeRKDV+H08jHEwoEAp+X0OaqyeXZL6RwfyI17r/VNgCoH8+Jl8JGd13BupUhfa cMFwju1h7l19utRI6sFTjj93AvDDe/5id1JgWe0S/xBwp29zanQe/6O+rF3chX1S pERClw4ryzv9Fa8GSegCJeefEqv/H5qUOg0XFTgnhmBR8N9431NXVQan/cRRyBHb VpderZqMo4Y2eTuZggH79DQMloykfNFvZV3Ev0FYheZbORpRCRAHX+TGh/LKg8OK vuk2Jv8OTpf+9NISm5sqf67lAeAVKUj26J06i9xQA1W4yppb5H0z3S04aLGQQaEN aJ1lPzYFvzenq9LZnkvNuXwZIAtq+w45wub4lp6mlS/f7I7AW8ZHCWZFjnI30Xv2 3bTUPtPCpy/bW8VOzZCYMQdPpeVdzQC8eUTOviS8Q/iCUQL+OoW9xUTNAHdwfIuy xCCAG9aVo4ycLCx4lLTCzFy2VcvQfeVKGaAhegVLl+WO/mo3lqhV6dlzKCv8zW5N sySTcMVNPIqHbUJRWoyjXxEtbSmgEc+5RFoZGv475SZuu7FmWow= =fBcx -----END PGP SIGNATURE----- --5zydvrs3eyercxdo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210420135450.ahbofrjlolqf5ivy>