Date: Sun, 22 Jul 2018 19:50:05 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229969] mixer_info modify_counter not incremented when are changes made to the mixer Message-ID: <bug-229969-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229969 Bug ID: 229969 Summary: mixer_info modify_counter not incremented when are changes made to the mixer Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: aliovx@gmail.com Created attachment 195378 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195378&action=edit Increment the modify_counter when mixer_set is called. >From sys/dev/sound/pcm/mixer.c:70 /** * Counter is incremented when applications change any of this * mixer's controls. A change in value indicates that persistent * mixer applications should update their displays. */ But reading the code, it is clear that this is not the case, and the counter remains 0. It is enough to call m->modify_counter++ in mixer_set on line 327 for example to make persistent mixer applications work correctly. Currently they have to poll for all mixer controls, even if no changes were made to the mixer. The attached patch solves the problem. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229969-227>