Date: Sat, 01 Dec 2018 17:02:38 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 233693] [PowerPC64] Powerd unable to change cpu frequency Message-ID: <bug-233693-227-dHcHZ1Ixvq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233693-227@https.bugs.freebsd.org/bugzilla/> References: <bug-233693-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233693 Conrad Meyer <cem@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |powerpc@FreeBSD.org CC| |cem@freebsd.org --- Comment #2 from Conrad Meyer <cem@freebsd.org> --- It doesn't fix this issue, but I suspect there is an off-by-one bug in pmcr_set(): --- a/sys/powerpc/cpufreq/pmcr.c +++ b/sys/powerpc/cpufreq/pmcr.c @@ -189,7 +190,7 @@ pmcr_set(device_t dev, const struct cf_setting *set) if (set =3D=3D NULL) return (EINVAL); - if (set->spec[0] < 0 || set->spec[0] > npstates) + if (set->spec[0] < 0 || set->spec[0] >=3D npstates) return (EINVAL); pmcr =3D ((long)pstate_ids[set->spec[0]] << PMCR_LOWERPS_SHIFT) & --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233693-227-dHcHZ1Ixvq>