Date: Wed, 10 Jun 2015 17:22:16 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com>, vbox@freebsd.org Subject: Re: virtualbox kmod build fix after r284215 Message-ID: <5578AA88.6040200@FreeBSD.org> In-Reply-To: <20150610194853.GF23380@dft-labs.eu> References: <20150610194853.GF23380@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 06/10/2015 15:48, Mateusz Guzik wrote:
> Hello,
>
> the following is needed since r284215 (__FreeBSD_version 1100077):
>
> --- ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c.orig
> 2015-06-10 19:30:28.355276494 +0000 +++
> ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c 2015-06-10
> 19:30:41.280304985 +0000 @@ -747,7 +747,7 @@ { /** @todo: is this
> needed?. */ PROC_LOCK(pProc); - AddrR3 =
> round_page((vm_offset_t)pProc->p_vmspace->vm_daddr + lim_max(pProc,
> RLIMIT_DATA)); + AddrR3 =
> round_page((vm_offset_t)pProc->p_vmspace->vm_daddr +
> lim_max_proc(pProc, RLIMIT_DATA)); PROC_UNLOCK(pProc); } else
Committed (r389147), thanks!
> Interestingly enough for some reason the build does not fail
> without the patch, even though resulting code is clearly broken as
> lim_max now expects a thread argument.
Yes, kernel module build is very fragile ATM and it should be fixed.
Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJVeKqIAAoJEHyflib82/FG6RMH/i6o37JDe+CY/m3K9GOaL9LM
e6Rn65pMarZUeU3TvNchtqaK2SZF2gGo2b0CPnrRddE6Ufomm5molazoGcs9nSJX
MqCHs0bisg4zyo37JOHOWPQ5go/J6hfO1pPCGBhQ8E3j2BpyeRJykebnOwUQ9Tei
G7mTV78l0joEjkrxXt55TYuARtTuY8ISlyfzyXibghVm1meNvz0/CLcadgUkgn1a
H42XSsBpaJpSLrv8MW7+7rm8snc/Z3zWwd8vGHjRcUfQbyvPCMhMuLntMyW+t2yx
Eij4QYe+h2yfIXPW1M3h8amOCkMT8hJlQEfC9ZcroPjtIdanwv+6DuNWOfBLQMM=
=twB8
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5578AA88.6040200>