Date: Sat, 15 Dec 2012 21:24:32 +0000 (UTC) From: Andrew Turner <andrew@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r244276 - head/contrib/gcc/config/arm Message-ID: <201212152124.qBFLOWDO040208@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: andrew Date: Sat Dec 15 21:24:31 2012 New Revision: 244276 URL: http://svnweb.freebsd.org/changeset/base/244276 Log: Don't define CTORS_SECTION_ASM_OP and DTORS_SECTION_ASM_OP on arm when built with clang. When these are defined the lists are defined similar to: asm(".section .ctors"); STATIC func_ptr __CTOR_LIST__[1] = { (func_ptr) (-1) }; asm(".section .dtors"); STATIC func_ptr __DTOR_LIST__[1] = { (func_ptr) (-1) }; The problem is clang will move the two arrays out of the .ctors and .dtors sections causing these sections to contain a single null address. By not defining these macros we use the version of the code that places the arrays is their sections by using __attribute__((section(".ctors"))) and similar for .dtors. Submitted by: Daisuke Aoyama <aoyama AT peach.ne.jp> Modified: head/contrib/gcc/config/arm/arm.h Modified: head/contrib/gcc/config/arm/arm.h ============================================================================== --- head/contrib/gcc/config/arm/arm.h Sat Dec 15 21:15:43 2012 (r244275) +++ head/contrib/gcc/config/arm/arm.h Sat Dec 15 21:24:31 2012 (r244276) @@ -1866,8 +1866,10 @@ typedef struct # define DTOR_LIST_BEGIN asm (ARM_EABI_DTORS_SECTION_OP) # define DTOR_LIST_END /* empty */ # else /* !defined (__ARM_EABI__) */ +# ifndef __clang__ # define CTORS_SECTION_ASM_OP ARM_CTORS_SECTION_OP # define DTORS_SECTION_ASM_OP ARM_DTORS_SECTION_OP +# endif # endif /* !defined (__ARM_EABI__) */ #endif /* !defined (IN_LIBCC2) */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212152124.qBFLOWDO040208>