Date: Tue, 17 Apr 2018 20:33:14 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227150] [NEW PORT] sysutils/rw: Block device and byte copying program similar to dd Message-ID: <bug-227150-7788-fjlLGiy1In@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227150-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-227150-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227150 --- Comment #5 from Mateusz Piotrowski <0mp@FreeBSD.org> --- (In reply to jsmith from comment #4) Cool! Thanks for updating the patch. There are, however, still a couple of issues: * The license is invalid. See Chapter 5.7 of the Porter's Handbook[1] for a list of valid license symbols. * There's probably no need to define do-install and do-build. The distribu= tion of rw has a Makefile, which does everything for us. Hint: you might want to define post-install in order to use ${STRIP_CMD}.[2]=20 * There are a lot of style problems. You my list them using portlint and t= hen fix warnings until portlint says "looks fine.". You may install portlint wi= th `pkg install ports-mgmt/portlint`. [1]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses= .html [2]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/install.= html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227150-7788-fjlLGiy1In>