Date: Wed, 13 Apr 2016 00:38:44 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 208754] games/assaultcube: Fix build with libc++ 3.8.0 Message-ID: <bug-208754-13-q4s4RXfH7S@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-208754-13@https.bugs.freebsd.org/bugzilla/> References: <bug-208754-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208754 lightside <lightside@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(lights |maintainer-feedback+ |ide@gmx.com) | --- Comment #1 from lightside <lightside@gmx.com> --- Hello, Dimitry Andric. Thanks for your patch. I found, that "hand-rolled" round() function was removed by upstream for development version also: https://github.com/assaultcube/AC/commit/752950989b4e286459ca9aee3d61a868d7= b20fa4 -8<-- fix some errors and warnings for GCC 6 * do not use std::abs() because math.h includes one, that converts ints to double. Use own iabs(), which directly uses labs() instead. * don't use the word "gamma" as name for variables * don't use a homebrew round() function -->8- There are also some upstream fixes for Clang warnings, some of which already included: https://github.com/assaultcube/AC/commit/6e4b23734f115888ce73907a85739ec833= a333fd Therefore, I propose to use mentioned upstream fixes (adapted for current 1.2.0.2 version), which includes your fix for round() function. The proposed patch attached to the following message. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-208754-13-q4s4RXfH7S>