Date: Tue, 22 Oct 2002 12:21:43 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mike Barcroft <mike@FreeBSD.org> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/isa npx.c Message-ID: <20021022121251.G12991-100000@gamplex.bde.org> In-Reply-To: <20021021100136.B80691@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 21 Oct 2002, Mike Barcroft wrote: > Poul-Henning Kamp <phk@critter.freebsd.dk> writes: > > In message <20021021093912.A80691@espresso.q9media.com>, Mike Barcroft writes: > > >Can your lint define a constant that is in the implementation > > >namespace (eg. _LINT)? This would at least improve your change to > > >i386's <machine/_types.h> which breaks things if an application > > >happens to `#define lint' in a C90 environment. > > > > Ohh, absolutely, that would be no problem at all. > > > > The problem is that "lint" is our standard for this: > > > > bang# sh /root/gsys lint | grep '#' | grep -v compile | wc -l > > 299 > > bang# sh /root/gsrc lint | grep '#' | grep -v compile | wc -l > > 5558 > > > > I'm not particularly attached to "lint", it can be any symbol we > > decide on, as long as we use the same one all over... > > Yes, but this is the second time ever "lint" has been used in a > standard header or in a header a standard header includes. The first > was in <sys/cdefs.h> about a month ago, but since it only modifies > macros in the implementation namespace it isn't a problem. The first is a problem, and is therefore not present in my version, since it breaks lint's detection of syntax errors like __packed and __alligned(). Syntax errors like __unused are not so bad provided they are restricted to implementation details since __unused doesn't change the semantics. The change that added these also has style bugs (unsorting of a sorted list and code no longer matching its comment). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021022121251.G12991-100000>