Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 28 Apr 2020 05:10:34 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r360428 - head/sbin/fsck_msdosfs
Message-ID:  <202004280510.03S5AYuJ076660@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: delphij
Date: Tue Apr 28 05:10:34 2020
New Revision: 360428
URL: https://svnweb.freebsd.org/changeset/base/360428

Log:
  Do not overflow when calculating file system size.
  
  Reported by:		Hyeongseok Kim <hyeongseok kim lge com>
  Reviewed by:		cem, Hyeongseok Kim
  MFC after:		3 days
  Differential Revision:	https://reviews.freebsd.org/D24603

Modified:
  head/sbin/fsck_msdosfs/check.c

Modified: head/sbin/fsck_msdosfs/check.c
==============================================================================
--- head/sbin/fsck_msdosfs/check.c	Tue Apr 28 03:43:55 2020	(r360427)
+++ head/sbin/fsck_msdosfs/check.c	Tue Apr 28 05:10:34 2020	(r360428)
@@ -54,6 +54,8 @@ checkfilesys(const char *fname)
 	int finish_dosdirsection=0;
 	int mod = 0;
 	int ret = 8;
+	int64_t freebytes;
+	int64_t badbytes;
 
 	rdonly = alwaysno;
 	if (!preen)
@@ -129,37 +131,33 @@ checkfilesys(const char *fname)
 			mod |= FSERROR;
 	}
 
+	freebytes = (int64_t)boot.NumFree * boot.ClusterSize;
+	badbytes = (int64_t)boot.NumBad * boot.ClusterSize;
+
 #ifdef HAVE_LIBUTIL_H
 	char freestr[7], badstr[7];
 
-	int64_t freebytes = boot.NumFree * boot.ClusterSize;
 	humanize_number(freestr, sizeof(freestr), freebytes, "",
 	    HN_AUTOSCALE, HN_DECIMAL | HN_IEC_PREFIXES);
 	if (boot.NumBad) {
-		int64_t badbytes = boot.NumBad * boot.ClusterSize;
-
 		humanize_number(badstr, sizeof(badstr), badbytes, "",
 		    HN_AUTOSCALE, HN_B | HN_DECIMAL | HN_IEC_PREFIXES);
 
 		pwarn("%d files, %sB free (%d clusters), %sB bad (%d clusters)\n",
-		      boot.NumFiles,
-		      freestr, boot.NumFree,
+		      boot.NumFiles, freestr, boot.NumFree,
 		      badstr, boot.NumBad);
 	} else {
 		pwarn("%d files, %sB free (%d clusters)\n",
-		      boot.NumFiles,
-		      freestr, boot.NumFree);
+		      boot.NumFiles, freestr, boot.NumFree);
 	}
 #else
 	if (boot.NumBad)
-		pwarn("%d files, %d KiB free (%d clusters), %d KiB bad (%d clusters)\n",
-		      boot.NumFiles,
-		      boot.NumFree * boot.ClusterSize / 1024, boot.NumFree,
-		      boot.NumBad * boot.ClusterSize / 1024, boot.NumBad);
+		pwarn("%d files, %jd KiB free (%d clusters), %jd KiB bad (%d clusters)\n",
+		      boot.NumFiles, (intmax_t)freebytes / 1024, boot.NumFree,
+		      (intmax_t)badbytes / 1024, boot.NumBad);
 	else
-		pwarn("%d files, %d KiB free (%d clusters)\n",
-		      boot.NumFiles,
-		      boot.NumFree * boot.ClusterSize / 1024, boot.NumFree);
+		pwarn("%d files, %jd KiB free (%d clusters)\n",
+		      boot.NumFiles, (intmax_t)freebytes / 1024, boot.NumFree);
 #endif
 
 	if (mod && (mod & FSERROR) == 0) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004280510.03S5AYuJ076660>