Date: Fri, 24 Sep 2010 14:17:29 +0400 From: pluknet <pluknet@gmail.com> To: Dag-Erling Smorgrav <des@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212723 - head/sys/compat/linprocfs Message-ID: <AANLkTi=20QDe6o2YxM8PTKOLXB3ZuxUCNQEPtWy9P4Rc@mail.gmail.com> In-Reply-To: <201009160756.o8G7uZrg065332@svn.freebsd.org> References: <201009160756.o8G7uZrg065332@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 September 2010 11:56, Dag-Erling Smorgrav <des@freebsd.org> wrote: > Author: des > Date: Thu Sep 16 07:56:34 2010 > New Revision: 212723 > URL: http://svn.freebsd.org/changeset/base/212723 > > Log: > =A0Implement proc/$$/environment. > [...] > =A0/* > =A0* Filler function for proc/pid/environ > =A0*/ > =A0static int > =A0linprocfs_doprocenviron(PFS_FILL_ARGS) > =A0{ > + =A0 =A0 =A0 int ret; > > - =A0 =A0 =A0 sbuf_printf(sb, "doprocenviron\n%c", '\0'); > - =A0 =A0 =A0 return (0); > + =A0 =A0 =A0 PROC_LOCK(p); With this change I observe the following sleepable after non-sleepable: 1st 0xffffff000290b558 process lock (process lock) @ /usr/src/sys/modules/linprocfs/../../compat/linprocfs/linprocfs.c:1049 2nd 0xffffff00028f8848 user map (user map) @ /usr/src/sys/vm/vm_map.c:3525 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2a _witness_debugger() at _witness_debugger+0x2e witness_checkorder() at witness_checkorder+0x807 _sx_slock() at _sx_slock+0x55 vm_map_lookup() at vm_map_lookup+0x55 vm_fault() at vm_fault+0x113 proc_rwmem() at proc_rwmem+0x7a linprocfs_doprocenviron() at linprocfs_doprocenviron+0x122 pfs_read() at pfs_read+0x45b vn_read() at vn_read+0x256 dofileread() at dofileread+0xa1 kern_readv() at kern_readv+0x60 read() at read+0x55 syscallenter() at syscallenter+0x1aa syscall() at syscall+0x4c Xfast_syscall() at Xfast_syscall+0xe2 --- syscall (3, FreeBSD ELF64, read), rip =3D 0x80074134c, rsp =3D 0x7fffffffe9c8, rbp =3D 0 --- > + > + =A0 =A0 =A0 if ((ret =3D p_cansee(td, p)) !=3D 0) { > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 PROC_UNLOCK(p); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ret; > + =A0 =A0 =A0 } > + > + =A0 =A0 =A0 ret =3D linprocfs_doargv(td, p, sb, ps_string_env); > + =A0 =A0 =A0 PROC_UNLOCK(p); > + =A0 =A0 =A0 return (ret); > =A0}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=20QDe6o2YxM8PTKOLXB3ZuxUCNQEPtWy9P4Rc>