Date: Sun, 17 Jan 2016 14:56:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206337] Fix devel/dee build with clang 3.8.0 Message-ID: <bug-206337-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206337 Bug ID: 206337 Summary: Fix devel/dee build with clang 3.8.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: olivierd@FreeBSD.org Reporter: dim@FreeBSD.org Assignee: olivierd@FreeBSD.org Flags: maintainer-feedback?(olivierd@FreeBSD.org) Created attachment 165718 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D165718&action= =3Dedit Parenthesize journal_iter_is_removed macro so it doesn't cause warnings During the exp-run in bug 206074, it was found that devel/dee gives errors = with a recent clang 3.8.0 snapshot: dee-transaction.c:1245:17: error: logical not is only applied to the left h= and side of this comparison [-Werror,-Wlogical-not-parentheses] g_assert (!journal_iter_is_removed (jiter)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/local/include/glib-2.0/glib/gtestutils.h:106:59: note: expanded from m= acro 'g_assert' if G_LIKELY (expr) ; else \ ^~~~ /usr/local/include/glib-2.0/glib/gmacros.h:325:59: note: expanded from macro 'G_LIKELY' #define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1)) ^~~~ /usr/local/include/glib-2.0/glib/gmacros.h:319:8: note: expanded from macro '_G_BOOLEAN_EXPR' if (expr) \ ^~~~ dee-transaction.c:1245:17: note: add parentheses after the '!' to evaluate = the comparison first dee-transaction.c:1245:17: note: add parentheses around left hand side expression to silence this warning 1 error generated. This is because the journal_iter_is_removed() macro does not have parenthes= es around its expression. Here is a patch to fix that. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206337-13>