Date: Sat, 29 Jan 2005 16:21:28 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: current@freebsd.org Subject: Re: We have a lot of duplicated code in the kernel Message-ID: <46996.1107012088@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 29 Jan 2005 16:10:22 %2B0100." <20050129161022.0de822fe@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20050129161022.0de822fe@Magellan.Leidinger.net>, Alexander Leidinger writes: >Hi, > >http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k) >contains a log of duplicated code in /sys (-current as of today). The >file starts with files with 20 consecutive lines of duplicated code and >ends with two files which share 1108 lines of code. > >If I let the program detect 6 consecutive lines of duplicated code, it >is also able to detect possible code reuse in the same file, but it also >prints a lot of "noise" then. > >I've filtered the list for some false positives (twa_fwimg, trlld?m, >if_patm_rtables), if someone else notices some more files please tell me >about them and I add them to the filter. And we'll soon see the tool which generates this in src/tools/tools somewhere I hope ? :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46996.1107012088>