Date: Wed, 2 Jul 2003 10:35:15 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20030702073515.GD58755@sunbay.com> In-Reply-To: <20030701184349.GB67015@dragon.nuxi.com> References: <200306300559.h5U5xZMr049298@repoman.freebsd.org> <20030630113741.GB8393@sunbay.com> <20030630155002.GL70590@roark.gnf.org> <20030630214757.GD57432@sunbay.com> <20030701184349.GB67015@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZJcv+A0YCCLh2VIg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jul 01, 2003 at 11:43:49AM -0700, David O'Brien wrote:
> On Tue, Jul 01, 2003 at 12:47:57AM +0300, Ruslan Ermilov wrote:
> > +.if exists(${.CURDIR}/rescue) && !defined(NO_RESCUE) && \
> > + ${BOOTSTRAPPING} < 501100
> > +_crunchgen=3D usr.sbin/crunch/crunchgen
> > +.endif
>=20
> Why do you need the "exists(${.CURDIR}/rescue)"? If this code made it to
> Makefile.inc1, src/rescue also made it to the checked out area.
>=20
> > +.if exists(${.CURDIR}/rescue) && !defined(NO_RESCUE) || \
> > + defined(RELEASEDIR)
> > +_crunchide=3D usr.sbin/crunch/crunchide
> > +.endif
>=20
> Same. Please simplify the logic.
>=20
Because this is consistent with the logic of constructing the
SUBDIR list. The committed version was ever more complicated,
but we now build these bits ONLY when necessary, as you have
requested some time ago (must admit I like it).
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
--ZJcv+A0YCCLh2VIg
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE/AoszUkv4P6juNwoRAr6EAJ49UfGwb3dSQd54gTbBu5i7FlHLNgCeIwch
dr3U/wLkNq3CXrX1jwK+DVE=
=P322
-----END PGP SIGNATURE-----
--ZJcv+A0YCCLh2VIg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030702073515.GD58755>