Date: Thu, 31 Jan 2013 04:14:22 +0400 (MSK) From: Dmitry Marakasov <amdmi3@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/175717: [Mk] do not require distinfo for for fetch-urlall-list Message-ID: <20130131001422.7BEAD7D6@hades.panopticon> Resent-Message-ID: <201301310020.r0V0K03U083751@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 175717
>Category: ports
>Synopsis: [Mk] do not require distinfo for for fetch-urlall-list
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 31 00:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Marakasov
>Release: FreeBSD 9.0-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Wed Jun 13 17:39:20 MSK 2012 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64
>Description:
make fetch-urlall-list won't work for a port without distinfo file:
---
% make fetch-urlall-list
/usr/bin/awk: can't open file /usr/ports/foo/bar/distinfo
source line number 1
*** Error code 2
Stop in /usr/ports/foo/bar.
*** Error code 1
Stop in /usr/ports/foo/bar.
---
this, however, is quite useful when creating new ports, where distinfo is not yet generated, but you want to check fetch list or fetch a distfile by hand.
Also, if an empty distinfo is created, fetch-urlall-list will work again correctly.
The patch attached fixes this problem by removing commands results of which are not even used from fetch-url-list-int target.
>How-To-Repeat:
For a random port, remove distinfo and try to run make fetch-urlall-list
>Fix:
--- bsd.port.mk.patch begins here ---
Index: bsd.port.mk
===================================================================
--- bsd.port.mk (revision 311274)
+++ bsd.port.mk (working copy)
@@ -4741,8 +4741,6 @@
SORTED_MASTER_SITES_CMD_TMP="${SORTED_MASTER_SITES_DEFAULT_CMD}" ; \
fi ; \
for site in `eval $$SORTED_MASTER_SITES_CMD_TMP ${_RANDOMIZE_SITES}`; do \
- DIR=${DIST_SUBDIR:S/\//\\\\\//g:S/./\\\\./g:S/+/\\\\+/g:S/?/\\\\?/g}; \
- CKSIZE=`${AWK} "/^SIZE \($${DIR:+$$DIR\/}$$fileptn\)/"'{print $$4}' ${DISTINFO_FILE}`; \
case $${file} in \
*/*) args="-o $${file} $${site}$${file}";; \
*) args=$${site}$${file};; \
@@ -4773,8 +4771,6 @@
SORTED_PATCH_SITES_CMD_TMP="${SORTED_PATCH_SITES_DEFAULT_CMD}" ; \
fi ; \
for site in `eval $$SORTED_PATCH_SITES_CMD_TMP ${_RANDOMIZE_SITES}`; do \
- DIR=${DIST_SUBDIR:S/\//\\\\\//g:S/./\\\\./g:S/+/\\\\+/g:S/?/\\\\?/g}; \
- CKSIZE=`${AWK} "/^SIZE \($${DIR:+$$DIR\/}$$fileptn\)/"'{print $$4}' ${DISTINFO_FILE}`; \
case $${file} in \
*/*) args="-o $${file} $${site}$${file}";; \
*) args=$${site}$${file};; \
--- bsd.port.mk.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130131001422.7BEAD7D6>