Date: Fri, 31 Jul 2009 08:53:52 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: pjd@FreeBSD.org Subject: Re: panic: mutex Giant owned at .../base/head/sys/kern/kern_exit.c:131 Message-ID: <200907310853.52946.jhb@freebsd.org> In-Reply-To: <152E0401-8750-4363-85D8-F058BD87C150@mac.com> References: <152E0401-8750-4363-85D8-F058BD87C150@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 31 July 2009 2:36:46 am Marcel Moolenaar wrote: > All, > > I got the following panic after I had to import my ZFS file system on > ia64. > The following panic happened when executing "zpool import": > > panic: mutex Giant owned at /nfs/freebsd/base/head/sys/kern/ > kern_exit.c:131 > cpuid = 0 > KDB: enter: panic It looks like ZFS doesn't actually ever check if any of the namei lookups it does internally return with Giant locked. For example, it doesn't check NDHASGIANT() in lookupnameat(). Fixing this may be a bit of work as I'm not sure it is safe to drop Giant right after the namei(). If it is because the end vnode's returned are always MPSAFE then that fix is easy. If not, then Giant needs to be held until the code stops frobbing the vnode returned from the lookup. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907310853.52946.jhb>