Date: Wed, 5 May 2004 03:45:06 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Doug Barton <DougB@DougBarton.net> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c Message-ID: <20040505033532.C11102@gamplex.bde.org> In-Reply-To: <40976D24.4060408@DougBarton.net> References: <200405040239.i442dfL0011742@repoman.freebsd.org> <40970329.3070507@freebsd.org> <40975C30.5D247B83@freebsd.org> <40976D24.4060408@DougBarton.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 May 2004, Doug Barton wrote:
> Andre Oppermann wrote:
>
> > However it worked for me just fine. The reason I just found out is that
> > I wasn't compiling if_vlan into the kernel but loaded and tested it as
> > module. Compiling it as module doesn't give any compiler warning and
> > works w/o a hitch. Dunno why?
>
> Testing both should be standard operating procedure before you commit.
> Of course there _should_ be no difference, but that's why you do testing
> on stuff like this.
The difference is because there is too much in kern.pre.mk. In
particular, the setting of -Werror. Only kern.mk is common to building
kernels and modules.
Other misplaced things: -D_KERNEL -fno-common -finline_limit=${INLINE_LIMIT}.
These are just duplicated, complete with icc ifdefs for the last 2.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040505033532.C11102>