Date: Thu, 11 Feb 2010 13:17:54 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Marcel Moolenaar <xcllnt@mac.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r203696 - in head: lib/libc/sys sys/kern sys/sys Message-ID: <20100211111754.GZ9991@deviant.kiev.zoral.com.ua> In-Reply-To: <FBE6FB42-0DE8-439C-9182-EFC3A81CABCF@mac.com> References: <201002090552.o195qZcD074581@svn.freebsd.org> <20100209095722.GQ9991@deviant.kiev.zoral.com.ua> <65DCE552-7EFD-48F2-85A4-EA0F1F0638EE@mac.com> <20100209184043.GV9991@deviant.kiev.zoral.com.ua> <896B58E6-12EA-48AB-86C2-5BA9F0C59512@mac.com> <86989446-64EF-411F-8E25-173DB6AEE10B@mac.com> <20100210091522.GW9991@deviant.kiev.zoral.com.ua> <FBE6FB42-0DE8-439C-9182-EFC3A81CABCF@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Feb 10, 2010 at 08:20:37PM -0800, Marcel Moolenaar wrote: > > On Feb 10, 2010, at 1:15 AM, Kostik Belousov wrote: > > > > Vnode locks are before vm map locks in global lock order. vn_fullpath() > > may need to lock vnodes to call VOP_VPTOCNP(). I think you should (and > > can) drop both vm map lock and vmspace reference much earlier. > > > > Would it be cleaner to use explicitely sized types for compat32 > > structure members ? > > I don't know. I prefer to keep them identical for as much as > that's possible. > > > Comparing ptrace_vm_entry with kinfo_vmentry, I think that it might > > be good idea to add fsid and inode number to ptrace_vm_entry, to > > give at least some information when vn_fullpath failed. > > How about the attached new path (includes man page as well)? > Looks good to me. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAktz52IACgkQC3+MBN1Mb4hUSgCgkJIIx61PSQafWrU7KsZ6tVqz BAQAn3bOAhoCD9lsFtrke+tBdPibkbek =pxMv -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100211111754.GZ9991>