Date: Thu, 26 Jun 2025 07:54:03 +0200 From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5c1ba994a8bc - main - Add a regression test for a libtpool bug Message-ID: <CA%2Bq%2BTcriXQzqGFZH0hWtqyPZGrhO2RPCrXr%2ByhkqCJGznzOJQA@mail.gmail.com> In-Reply-To: <202506151602.55FG2SHe047772@gitrepo.freebsd.org> References: <202506151602.55FG2SHe047772@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000ff0aa206387330ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Alan, On Sun, Jun 15, 2025 at 6:02=E2=80=AFPM Alan Somers <asomers@freebsd.org> w= rote: > The branch main has been updated by asomers: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D5c1ba994a8bcb6676ea3d1bb21b072b= 90e2d3ae9 > > commit 5c1ba994a8bcb6676ea3d1bb21b072b90e2d3ae9 > Author: Alan Somers <asomers@FreeBSD.org> > AuthorDate: 2024-05-07 17:48:33 +0000 > Commit: Alan Somers <asomers@FreeBSD.org> > CommitDate: 2025-06-15 16:01:37 +0000 > > Add a regression test for a libtpool bug > > > It seems this commit is the cause of preventing all my (freshly installed) ZFS systems from booting than stop with: Mounting local filesystems:. ld-elf.so.1: Shared object "libtpool.so.2" not found, required by "zfs" Because liptpool.so.2 isn=E2=80=99t no more in /lib (belong to the / datase= t), but in another dataset (/usr/lib) but it needs to use zfs to mount this one. Could the added include<src.opts.mk> in its Makefile modified the installed directory of libtpool.so.2 ? Here is the bisect script used: #!/bin/sh set -eu WRKDIR=3D/tmp/bisec mkdir -p $WRKDIR/lib $WRKDIR/usr/lib $WRKDIR/usr/include make -C cddl/lib/libtpool make -C cddl/lib/libtpool install DESTDIR=3D$WRKDIR if [ -f $WRKDIR/lib/libtpool.so.2 ]; then rm -rf $WRKDIR exit 0 else rm -rf $WRKDIR exit 1 fi And my bisect session pointed me to this commit. git bisect start HEAD 9ce5410b9094 -- git bisect run /tmp/bisec.libtpool.sh git bisect reset Regards, Olivier --000000000000ff0aa206387330ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_defa= ult" style=3D"font-family:"courier new",monospace">Hi Alan,</div>= <div class=3D"gmail_default" style=3D"font-family:"courier new",m= onospace"><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" c= lass=3D"gmail_attr">On Sun, Jun 15, 2025 at 6:02=E2=80=AFPM Alan Somers <= ;<a href=3D"mailto:asomers@freebsd.org" target=3D"_blank">asomers@freebsd.o= rg</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi= n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex= ">The branch main has been updated by asomers:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D5c1ba994a8bcb6676= ea3d1bb21b072b90e2d3ae9" rel=3D"noreferrer" target=3D"_blank">https://cgit.= FreeBSD.org/src/commit/?id=3D5c1ba994a8bcb6676ea3d1bb21b072b90e2d3ae9</a><b= r> <br> commit 5c1ba994a8bcb6676ea3d1bb21b072b90e2d3ae9<br> Author:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org><br> AuthorDate: 2024-05-07 17:48:33 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org><br> CommitDate: 2025-06-15 16:01:37 +0000<br> <br> =C2=A0 =C2=A0 Add a regression test for a libtpool bug<br> <br><br></blockquote><div><br></div><div class=3D"gmail_default" style=3D"f= ont-family:"courier new",monospace">It seems this commit is the c= ause of preventing all my (freshly installed) ZFS systems from booting than= stop with:</div><div class=3D"gmail_default" style=3D"font-family:"co= urier new",monospace"><br></div><div class=3D"gmail_default" style=3D"= font-family:"courier new",monospace">Mounting local filesystems:.= <br>ld-elf.so.1: Shared object "libtpool.so.2" not found, require= d by "zfs"</div><div class=3D"gmail_default" style=3D"font-family= :"courier new",monospace"><br></div><div class=3D"gmail_default" = style=3D"font-family:"courier new",monospace">Because liptpool.so= .2 isn=E2=80=99t no more in /lib (belong to the / dataset), but in another = dataset (/usr/lib) but it needs to use zfs to mount this one.</div><div cla= ss=3D"gmail_default" style=3D"font-family:"courier new",monospace= "><br></div><div class=3D"gmail_default" style=3D"font-family:"courier= new",monospace">Could the added include<<a href=3D"http://src.opts= .mk" target=3D"_blank">src.opts.mk</a>> in its Makefile modified the ins= talled directory of=C2=A0libtpool.so.2 ?</div><div class=3D"gmail_default" = style=3D"font-family:"courier new",monospace"><br></div><div clas= s=3D"gmail_default" style=3D"font-family:"courier new",monospace"= >Here is the bisect script used:</div><div class=3D"gmail_default" style=3D= "font-family:"courier new",monospace"><br>#!/bin/sh<br>set -eu<br= >WRKDIR=3D/tmp/bisec<br>mkdir -p $WRKDIR/lib $WRKDIR/usr/lib $WRKDIR/usr/in= clude<br>make -C cddl/lib/libtpool<br>make -C cddl/lib/libtpool install DES= TDIR=3D$WRKDIR<br>if [ -f $WRKDIR/lib/libtpool.so.2 ]; then<br>=C2=A0 =C2= =A0 rm -rf $WRKDIR<br>=C2=A0 =C2=A0 exit 0<br>else<br>=C2=A0 =C2=A0 rm -rf = $WRKDIR<br>=C2=A0 =C2=A0 exit 1<br>fi</div><div class=3D"gmail_default" sty= le=3D"font-family:"courier new",monospace"><br></div><div class= =3D"gmail_default" style=3D"font-family:"courier new",monospace">= And my bisect session pointed me to this commit.</div><div class=3D"gmail_d= efault" style=3D"font-family:"courier new",monospace">git bisect = start HEAD 9ce5410b9094 -- <br>git bisect run /tmp/<a href=3D"http://bisec.= libtpool.sh" target=3D"_blank">bisec.libtpool.sh</a><br>git bisect reset</d= iv><div class=3D"gmail_default" style=3D"font-family:"courier new"= ;,monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:&q= uot;courier new",monospace">Regards,</div><div class=3D"gmail_default"= style=3D"font-family:"courier new",monospace">Olivier</div></div= ></div> </div> --000000000000ff0aa206387330ac--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2Bq%2BTcriXQzqGFZH0hWtqyPZGrhO2RPCrXr%2ByhkqCJGznzOJQA>