Date: Tue, 7 Mar 2017 01:12:31 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin Message-ID: <C564389B-E51F-439B-843C-8EFE9EAD9EE4@gmail.com> In-Reply-To: <201703070904.v2794RLY093614@pdx.rh.CN85.dnsmgr.net> References: <201703070904.v2794RLY093614@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 7, 2017, at 01:04, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >=20 >>>=20 >>> On Mar 6, 2017, at 21:50, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >>>=20 >>>>> On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes@FreeBSD.org> = wrote: >>>>>=20 >>>>> Author: rgrimes >>>>> Date: Tue Mar 7 05:10:38 2017 >>>>> New Revision: 314833 >>>>> URL: https://svnweb.freebsd.org/changeset/base/314833 >>> ... >>>=20 >>>>>=20 >>>>> -SYMLINKS+=3D ${LIBDIR}/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>>>> +SYMLINKS+=3D ../../../tests/lib/libxo/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>>>=20 >>>> This change breaks setting TESTSBASE !=3D /usr/tests . Please = fix (my employer depends on this being functional). >>>> Thanks, >>>=20 >>> I am just going to revert this until the issue with SYMLINKS vs = RSYMLINKS and >>> probably a much better fix in bsd.*.mk can be implemented. I can = live with >>> one last nasty wart of an absolute link in DESTDIR until then. The = important >>> functional ones are gone now. >>>=20 >>> To fix this without changing SYMLINKS would involve adding a local = install: >>> target which would be more mess than having the one absolute link. >>=20 >> The proposed enhancement for bsd.links.mk for RSYMLINKS can be found = here: https://reviews.freebsd.org/D9919 . >=20 > I dont think that is what bapt/bdrewery had in mind, I think they = wanted to > replicate the SYMLINK=3D as RSYMLINK=3D and use that when needed. >=20 > I have thought about this and we do not ever want absolute links in = the tree, > so much simpler fix is to just convert SYMLINKS to call = INSTALL_RSYMLINKS > instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be = fixed, > and as long as no one uses INSTALL_SYMLINKS. SYMLINKS has been around since r245752. I personally don=E2=80=99t know = if it=E2=80=99s wise to remove functionality that=E2=80=99s been =E2=80=9C= in production=E2=80=9D for 4+ years. Making the target intelligently use one command over the other might = seem ok, but it could have unintended consequences. I think it=E2=80=99s = best to have another well-documented variable that uses INSTALL_RSYMLINK = vs INSTALL_SYMLINK. Also, in the CR, please note that the SYMLINKS piece doesn=E2=80=99t = prefix source targets with ${DESTDIR}, whereas the LINKS (and soon to be = RSYMLINKS portion) will need it in order to compute the right paths and = execute the right behavior. Otherwise, you=E2=80=99re going to be = breaking someone=E2=80=99s use for SYMLINKS for no good reason. Thanks, -Ngie --Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvnl/AAoJEPWDqSZpMIYV9FwP/RMj3HAeTCsRRR2RtR4qQf7Y Kx/SLxc9DMPwCBMja2H8U00SEItld294N+Ze3V0Kxp1amFEhMuhgiDRdwRhLGTMp 8VkN8EIBqBAAfr3i6/0bmyHYxV4HhDRTRsSg4dX3UfxiTXo+cJDSBiCiZp+kr8B6 9kK9wNeKucR8Lu3TsH8vwwLYEq/+wVwYeLPbRjIxbMrYpbWUw/nm+PB9S2gfqDxH uwr9+a4zCWL4GWuc6AuKnw0N8Ixc2YqdreiozETVqcvv6Xv7LElyYVNqD8zsjbO/ cIRpnHjlQykZ75xEl7m4GvTJvH4C81SRmxQLQPjwyNPrJ63T6z1HeOU7uiBtud+d opADMG0phZtT95p+PKZe7HHRQMDit0BAA0C4QZzJW+7zmCHgAMddF6ld7bfujaO5 8vybSn/1KlBpdlNDL9IljDTkwrvy++jp/4FWGgkrBlwn5Z7nLZq3EZMKU/UyGmXe N5QM7uVsFHIeniYDcwtSswAsVdyWQNyXlsuGE0TKN4xCiiR1xIZi081qIACyuwhU mfV5gLLaNjN/J8yVGOWNdXGTqkg5UWWUoRd2o+MLgHxGfQnojY10bJ+Jdf05CI5Z XZcxs6RU54tWiBC4338ImoxrntOFtW5c1C98pocS0PV4ddxMBjhJ9cKMiwp/01sR q5MO6RCRe8/K06RoWZL7 =fZs5 -----END PGP SIGNATURE----- --Apple-Mail=_6FD328DE-9B26-4456-B9FB-36A36D79A277--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C564389B-E51F-439B-843C-8EFE9EAD9EE4>