Date: Tue, 20 Mar 2012 18:36:11 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Davide Italiano <davide.italiano@gmail.com> Cc: svn-src-head@FreeBSD.org, George Neville-Neil <gnn@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r233045 - in head/sys: conf kern Message-ID: <20120320143611.GH30704@FreeBSD.org> In-Reply-To: <CACYV=-HnKmkcw-p2i9o_VyKGkp6V5yzO0B61uCBOAebg=VHd-A@mail.gmail.com> References: <201203162032.q2GKWBRV033715@svn.freebsd.org> <20120319194431.GD30704@FreeBSD.org> <CACYV=-EmbDNep1rPwF6jfHB2M8JuhLDFvrsvZoBMuVB7kOC1bA@mail.gmail.com> <CACYV=-HnKmkcw-p2i9o_VyKGkp6V5yzO0B61uCBOAebg=VHd-A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: D> >> These indented ifdefs look like a major violation of style used throughout D> >> the FreeBSD kernel code. Can you please keep with common style? D> >> D> > D> > Heh, D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and D> > after I'll have approval from my mentor I'll commit. Looks okay, apart from additional empty line in NOTES. Isn't single empty line enough? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120320143611.GH30704>