Date: Sun, 31 May 2026 21:31:05 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Eric Turgeon <ericbsd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c63cde2c2486 - main - deskutils/mate-utils: switch to GitHub release asset Message-ID: <CAFDf7ULMfh-%2ByH_EeKmEQJoCKBGMzaRahnDaD9VAQxb1hnA2eQ@mail.gmail.com> In-Reply-To: <6a1c8ace.25d84.7921a681@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] You continue to commit the same wrong use of USE_GITHUB=nodefault that do not applies for your changes to a single distfile with MASTER_SITES defined. There are about 12 or more commits with this kind of errors and several replies to your commits telling and explaining why that's wrong and you still continue committing ignoring them. How do you plan fix all of these? Thanks, Eric Turgeon <ericbsd@freebsd.org> escreveu (domingo, 31/05/2026 à(s) 20:24): > The branch main has been updated by ericbsd: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=c63cde2c2486e64ac6f05fce2d612afb46e2de79 > > commit c63cde2c2486e64ac6f05fce2d612afb46e2de79 > Author: Eric Turgeon <ericbsd@FreeBSD.org> > AuthorDate: 2026-05-31 19:23:54 +0000 > Commit: Eric Turgeon <ericbsd@FreeBSD.org> > CommitDate: 2026-05-31 19:23:54 +0000 > > deskutils/mate-utils: switch to GitHub release asset > > Minor versions of 1.28.x are no longer published to the MATE mirror > and are only available on GitHub. Use USE_GITHUB=nodefault with a > release tarball instead of the auto-generated one, as recommended > by the porter's handbook. Remove autoreconf, gtkdocize, > autoconf-archive, yelp-tools, and GH_TUPLE submodules, not needed > with release tarballs. Add libudisks2 dependency and enable the disk > image mounter. Patch mate-dictionary/Makefile.in to skip installing > pre-built API docs. > --- > deskutils/mate-utils/Makefile | 24 > +++++++++------------- > deskutils/mate-utils/distinfo | 8 +++----- > .../files/patch-mate-dictionary_Makefile.in | 11 ++++++++++ > deskutils/mate-utils/pkg-plist | 2 ++ > 4 files changed, 26 insertions(+), 19 deletions(-) > > diff --git a/deskutils/mate-utils/Makefile b/deskutils/mate-utils/Makefile > index 8d770a35398e..eecb87fc6793 100644 > --- a/deskutils/mate-utils/Makefile > +++ b/deskutils/mate-utils/Makefile > @@ -1,7 +1,9 @@ > PORTNAME= mate-utils > -DISTVERSIONPREFIX= v > DISTVERSION= 1.28.0 > +PORTREVISION= 1 > CATEGORIES= deskutils mate > +MASTER_SITES= > https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/releases/download/v${DISTVERSION}/ > +DISTFILES= ${DISTNAME}${EXTRACT_SUFX} > > MAINTAINER= gnome@FreeBSD.org > COMMENT= MATE support utilities > @@ -13,21 +15,16 @@ LICENSE_FILE_GPLv2+ = ${WRKSRC}/COPYING > LICENSE_FILE_GFDL= ${WRKSRC}/COPYING.docs > LICENSE_FILE_LGPL20+ = ${WRKSRC}/COPYING.libs > > -BUILD_DEPENDS= itstool:textproc/itstool \ > - gtkdocize:textproc/gtk-doc \ > - autoconf-archive>=0:devel/autoconf-archive \ > - yelp-tools>=0:textproc/yelp-tools > +BUILD_DEPENDS= itstool:textproc/itstool > > LIB_DEPENDS= libgtop-2.0.so:devel/libgtop \ > - libcanberra-gtk3.so:audio/libcanberra-gtk3 > + libcanberra-gtk3.so:audio/libcanberra-gtk3 \ > + libudisks2.so:sysutils/libudisks > > -PORTSCOUT= limitw:1,even > - > -USE_GITHUB= yes > +USES= gettext gmake gnome libtool localbase mate \ > + pkgconfig tar:xz xorg > +USE_GITHUB= nodefault > GH_ACCOUNT= mate-desktop > -GH_TUPLE= > mate-desktop:mate-submodules:54fff1b:submodules/gsearchtool/mate-submodules > -USES= autoreconf gettext gmake gnome libtool localbase mate \ > - pkgconfig xorg > USE_MATE= panel common:build > USE_XORG= ice sm x11 xext > USE_GNOME= cairo gnomeprefix gtk30 intltool > @@ -36,8 +33,7 @@ GNU_CONFIGURE= yes > GNU_CONFIGURE_MANPREFIX=${PREFIX}/share > INSTALL_TARGET= install-strip > > -CONFIGURE_ARGS= --disable-disk-image-mounter \ > - --disable-gtk-doc > +PORTSCOUT= limitw:1,even > > GLIB_SCHEMAS= org.mate.dictionary.gschema.xml \ > org.mate.disk-usage-analyzer.gschema.xml \ > diff --git a/deskutils/mate-utils/distinfo b/deskutils/mate-utils/distinfo > index 5142c29b9abd..d1987833e09e 100644 > --- a/deskutils/mate-utils/distinfo > +++ b/deskutils/mate-utils/distinfo > @@ -1,5 +1,3 @@ > -TIMESTAMP = 1779795940 > -SHA256 (mate-desktop-mate-utils-v1.28.0_GH0.tar.gz) = > 17e36b6df50f58286d35cd0742623427e5d7b99923b861f9d400341d49a96a7d > -SIZE (mate-desktop-mate-utils-v1.28.0_GH0.tar.gz) = 10258702 > -SHA256 (mate-desktop-mate-submodules-54fff1b_GH0.tar.gz) = > 66cde56dacbd15b7134f51c0f80e6567ee7af05157711ce3ef49973718433b7b > -SIZE (mate-desktop-mate-submodules-54fff1b_GH0.tar.gz) = 33344 > +TIMESTAMP = 1780225731 > +SHA256 (mate-utils-1.28.0.tar.xz) = > 58449d7a0d1d900ff03b78ca9f7e98c21e97f47fc26bee7ff1c61834f22f88d3 > +SIZE (mate-utils-1.28.0.tar.xz) = 7986440 > diff --git a/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in > b/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in > new file mode 100644 > index 000000000000..5ab9e5434e86 > --- /dev/null > +++ b/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in > @@ -0,0 +1,11 @@ > +--- mate-dictionary/Makefile.in.orig 2026-05-31 11:26:40 UTC > ++++ mate-dictionary/Makefile.in > +@@ -413,7 +413,7 @@ top_srcdir = @top_srcdir@ > + top_build_prefix = @top_build_prefix@ > + top_builddir = @top_builddir@ > + top_srcdir = @top_srcdir@ > +-SUBDIRS = libgdict src data docs help > ++SUBDIRS = libgdict src data help > + EXTRA_DIST = TODO README.md AUTHORS > + all: all-recursive > + > diff --git a/deskutils/mate-utils/pkg-plist > b/deskutils/mate-utils/pkg-plist > index 83aa86ded217..eb65a14149af 100644 > --- a/deskutils/mate-utils/pkg-plist > +++ b/deskutils/mate-utils/pkg-plist > @@ -1,4 +1,5 @@ > bin/mate-dictionary > +bin/mate-disk-image-mounter > bin/mate-disk-usage-analyzer > bin/mate-panel-screenshot > bin/mate-screenshot > @@ -24,6 +25,7 @@ lib/libmatedict.so.6.0.7 > libdata/pkgconfig/mate-dict.pc > libexec/mate-dictionary-applet > share/applications/mate-dictionary.desktop > +share/applications/mate-disk-image-mounter.desktop > share/applications/mate-disk-usage-analyzer.desktop > share/applications/mate-screenshot.desktop > share/applications/mate-search-tool.desktop > > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div><div><div>You continue to commit the same wrong use of USE_GITHUB=nodefault that do not applies for your changes to a single distfile with MASTER_SITES defined.<br></div>There are about 12 or more commits with this kind of errors and several replies to your commits telling and explaining why that's wrong and you still continue committing ignoring them.<br><br></div>How do you plan fix all of these?<br><br></div>Thanks,</div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Eric Turgeon <<a href="mailto:ericbsd@freebsd.org">ericbsd@freebsd.org</a>> escreveu (domingo, 31/05/2026 à(s) 20:24):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by ericbsd:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=c63cde2c2486e64ac6f05fce2d612afb46e2de79" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=c63cde2c2486e64ac6f05fce2d612afb46e2de79</a><br>; <br> commit c63cde2c2486e64ac6f05fce2d612afb46e2de79<br> Author: Eric Turgeon <ericbsd@FreeBSD.org><br> AuthorDate: 2026-05-31 19:23:54 +0000<br> Commit: Eric Turgeon <ericbsd@FreeBSD.org><br> CommitDate: 2026-05-31 19:23:54 +0000<br> <br> deskutils/mate-utils: switch to GitHub release asset<br> <br> Minor versions of 1.28.x are no longer published to the MATE mirror<br> and are only available on GitHub. Use USE_GITHUB=nodefault with a<br> release tarball instead of the auto-generated one, as recommended<br> by the porter's handbook. Remove autoreconf, gtkdocize,<br> autoconf-archive, yelp-tools, and GH_TUPLE submodules, not needed<br> with release tarballs. Add libudisks2 dependency and enable the disk<br> image mounter. Patch mate-dictionary/Makefile.in to skip installing<br> pre-built API docs.<br> ---<br> deskutils/mate-utils/Makefile | 24 +++++++++-------------<br> deskutils/mate-utils/distinfo | 8 +++-----<br> .../files/patch-mate-dictionary_Makefile.in | 11 ++++++++++<br> deskutils/mate-utils/pkg-plist | 2 ++<br> 4 files changed, 26 insertions(+), 19 deletions(-)<br> <br> diff --git a/deskutils/mate-utils/Makefile b/deskutils/mate-utils/Makefile<br> index 8d770a35398e..eecb87fc6793 100644<br> --- a/deskutils/mate-utils/Makefile<br> +++ b/deskutils/mate-utils/Makefile<br> @@ -1,7 +1,9 @@<br> PORTNAME= mate-utils<br> -DISTVERSIONPREFIX= v<br> DISTVERSION= 1.28.0<br> +PORTREVISION= 1<br> CATEGORIES= deskutils mate<br> +MASTER_SITES= <a href="https://github.com/$%7BGH_ACCOUNT%7D/$%7BGH_PROJECT%7D/releases/download/v$%7BDISTVERSION%7D/" rel="noreferrer" target="_blank">https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/releases/download/v${DISTVERSION}/</a><br>; +DISTFILES= ${DISTNAME}${EXTRACT_SUFX}<br> <br> MAINTAINER= gnome@FreeBSD.org<br> COMMENT= MATE support utilities<br> @@ -13,21 +15,16 @@ LICENSE_FILE_GPLv2+ = ${WRKSRC}/COPYING<br> LICENSE_FILE_GFDL= ${WRKSRC}/COPYING.docs<br> LICENSE_FILE_LGPL20+ = ${WRKSRC}/COPYING.libs<br> <br> -BUILD_DEPENDS= itstool:textproc/itstool \<br> - gtkdocize:textproc/gtk-doc \<br> - autoconf-archive>=0:devel/autoconf-archive \<br> - yelp-tools>=0:textproc/yelp-tools<br> +BUILD_DEPENDS= itstool:textproc/itstool<br> <br> LIB_DEPENDS= libgtop-2.0.so:devel/libgtop \<br> - libcanberra-gtk3.so:audio/libcanberra-gtk3<br> + libcanberra-gtk3.so:audio/libcanberra-gtk3 \<br> + libudisks2.so:sysutils/libudisks<br> <br> -PORTSCOUT= limitw:1,even<br> -<br> -USE_GITHUB= yes<br> +USES= gettext gmake gnome libtool localbase mate \<br> + pkgconfig tar:xz xorg<br> +USE_GITHUB= nodefault<br> GH_ACCOUNT= mate-desktop<br> -GH_TUPLE= mate-desktop:mate-submodules:54fff1b:submodules/gsearchtool/mate-submodules<br> -USES= autoreconf gettext gmake gnome libtool localbase mate \<br> - pkgconfig xorg<br> USE_MATE= panel common:build<br> USE_XORG= ice sm x11 xext<br> USE_GNOME= cairo gnomeprefix gtk30 intltool<br> @@ -36,8 +33,7 @@ GNU_CONFIGURE= yes<br> GNU_CONFIGURE_MANPREFIX=${PREFIX}/share<br> INSTALL_TARGET= install-strip<br> <br> -CONFIGURE_ARGS= --disable-disk-image-mounter \<br> - --disable-gtk-doc<br> +PORTSCOUT= limitw:1,even<br> <br> GLIB_SCHEMAS= org.mate.dictionary.gschema.xml \<br> org.mate.disk-usage-analyzer.gschema.xml \<br> diff --git a/deskutils/mate-utils/distinfo b/deskutils/mate-utils/distinfo<br> index 5142c29b9abd..d1987833e09e 100644<br> --- a/deskutils/mate-utils/distinfo<br> +++ b/deskutils/mate-utils/distinfo<br> @@ -1,5 +1,3 @@<br> -TIMESTAMP = 1779795940<br> -SHA256 (mate-desktop-mate-utils-v1.28.0_GH0.tar.gz) = 17e36b6df50f58286d35cd0742623427e5d7b99923b861f9d400341d49a96a7d<br> -SIZE (mate-desktop-mate-utils-v1.28.0_GH0.tar.gz) = 10258702<br> -SHA256 (mate-desktop-mate-submodules-54fff1b_GH0.tar.gz) = 66cde56dacbd15b7134f51c0f80e6567ee7af05157711ce3ef49973718433b7b<br> -SIZE (mate-desktop-mate-submodules-54fff1b_GH0.tar.gz) = 33344<br> +TIMESTAMP = 1780225731<br> +SHA256 (mate-utils-1.28.0.tar.xz) = 58449d7a0d1d900ff03b78ca9f7e98c21e97f47fc26bee7ff1c61834f22f88d3<br> +SIZE (mate-utils-1.28.0.tar.xz) = 7986440<br> diff --git a/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in b/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in<br> new file mode 100644<br> index 000000000000..5ab9e5434e86<br> --- /dev/null<br> +++ b/deskutils/mate-utils/files/patch-mate-dictionary_Makefile.in<br> @@ -0,0 +1,11 @@<br> +--- mate-dictionary/Makefile.in.orig 2026-05-31 11:26:40 UTC<br> ++++ mate-dictionary/Makefile.in<br> +@@ -413,7 +413,7 @@ top_srcdir = @top_srcdir@<br> + top_build_prefix = @top_build_prefix@<br> + top_builddir = @top_builddir@<br> + top_srcdir = @top_srcdir@<br> +-SUBDIRS = libgdict src data docs help<br> ++SUBDIRS = libgdict src data help<br> + EXTRA_DIST = TODO README.md AUTHORS<br> + all: all-recursive<br> + <br> diff --git a/deskutils/mate-utils/pkg-plist b/deskutils/mate-utils/pkg-plist<br> index 83aa86ded217..eb65a14149af 100644<br> --- a/deskutils/mate-utils/pkg-plist<br> +++ b/deskutils/mate-utils/pkg-plist<br> @@ -1,4 +1,5 @@<br> bin/mate-dictionary<br> +bin/mate-disk-image-mounter<br> bin/mate-disk-usage-analyzer<br> bin/mate-panel-screenshot<br> bin/mate-screenshot<br> @@ -24,6 +25,7 @@ lib/libmatedict.so.6.0.7<br> libdata/pkgconfig/mate-dict.pc<br> libexec/mate-dictionary-applet<br> share/applications/mate-dictionary.desktop<br> +share/applications/mate-disk-image-mounter.desktop<br> share/applications/mate-disk-usage-analyzer.desktop<br> share/applications/mate-screenshot.desktop<br> share/applications/mate-search-tool.desktop<br> <br> </blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7ULMfh-%2ByH_EeKmEQJoCKBGMzaRahnDaD9VAQxb1hnA2eQ>