Date: Thu, 13 Jun 2002 14:23:28 -0400 From: Mikhail Teterin <mi+mx@aldan.algebra.com> To: Pete Fritchman <petef@absolutbsd.org> Cc: Maxim Sobolev <sobomax@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/eel2/files patch-Makefile.in Message-ID: <200206131423.28423.mi%2Bmx@aldan.algebra.com> In-Reply-To: <20020613141226.A55226@absolutbsd.org> References: <200206131606.g5DG6PW29106@freefall.freebsd.org> <200206131402.14393.mi%2Bmx@aldan.algebra.com> <20020613141226.A55226@absolutbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[moved to -ports] On Thursday 13 June 2002 02:12 pm, Pete Fritchman wrote: = ++ 13/06/02 14:02 -0400 - Mikhail Teterin: = | On Thursday 13 June 2002 12:06 pm, Maxim Sobolev wrote: = | = sobomax 2002/06/13 09:06:25 PDT = | = = | = Added files: = | = x11-toolkits/eel2/files patch-Makefile.in = | = Log: = | = Don't bother to build tests which aren't installed anyway. = | = | Wouldn't it be better to modify the port to _run_ the tests after = | the build? Speak of QA skills... = = That should probably be left up to the maintainer to do before = committing the port... for example, none of the p5-* ports run a "make = test" during the build stage, but before I ever commit a new/updated = p5 port I run a "make test" to see that it works OK... Actually, the very lang/perl fails some locale-related tests :-) Seriously, too much can be different between your machine and that of someone, who just built the port. IMO, the built-in tests, that a lot of software has, should be used -- unless the tests themselves are broken, as is the case with many Tcl and Tk tests, regretfully. In fact, ``test'' should be a standard target in a port's Makefile -- between ``build'' and ``install''. Unusual WITH/WITHOUT options, CFLAGS, dependencies' combinations can all result in breakage. Detecting such breakage prior to install would definetly be a Good Thing (TM). = Perhaps we should adopt OpenBSD's testing/regress infrastructure for = ports? -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206131423.28423.mi%2Bmx>