Date: Fri, 4 Nov 2016 06:31:20 -0300 From: Jared McNeill <jmcneill@invisible.ca> To: Milan Obuch <freebsd-arm@dino.sk> Cc: freebsd-arm@freebsd.org Subject: Re: aw_thermal breakage on Allwinner H3 SoC Message-ID: <EDD07928-1239-4184-8221-767E5E7C6613@invisible.ca> In-Reply-To: <20161103123445.6bcc4799@zeta.dino.sk> References: <20161024165820.16e6dd6f@zeta.dino.sk> <alpine.DEB.2.11.1610251058480.641@dis.invisible.ca> <alpine.DEB.2.11.1610251208390.641@dis.invisible.ca> <20161025180314.38ea1e96@zeta.dino.sk> <20161025202609.0958c55d@zeta.dino.sk> <20161025213913.310b502e@zeta.dino.sk> <alpine.DEB.2.11.1610251724430.641@dis.invisible.ca> <20161103123445.6bcc4799@zeta.dino.sk>
index | next in thread | previous in thread | raw e-mail
It would look similar to the thermal zone definition in sun7i-a20.dtsi. Maybe in the short term we can add some tunables with sane defaults in aw_thermal. > On Nov 3, 2016, at 8:34 AM, Milan Obuch <freebsd-arm@dino.sk> wrote: > > On Tue, 25 Oct 2016 17:38:55 -0300 (ADT) > Jared McNeill <jmcneill@invisible.ca> wrote: > >>> On Tue, 25 Oct 2016, Milan Obuch wrote: >>> >>> One more observation: booting verbose shows following >>> aw_thermal0: <Allwinner Thermal Sensor Controller> mem >>> 0x1c25000-0x1c253ff irq 29 on simplebus0 aw_thermal0: #0: alarm 42C >>> hyst 15C shut 65C >>> >>> which is for me wrong - shutdown temperature 65 degrees is >>> unacceptably low. >> >> Agreed. Those numbers are the SoC default values. >> >> It looks like the thresholds should be defined in a thermal-zones >> node in the dts, but there is none defined in sun8i-h3.dtsi. We'll >> have to come up with some reasonable defaults, add them to our dts, >> and then add support for reading the trip points to the aw_thermal >> driver. >> >> Cheers, >> Jared > > How could this get done? Do we have any example (in some other dts) how > this definition should look like? Where do these vaules got read from? > > Regards, > Milanhelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EDD07928-1239-4184-8221-767E5E7C6613>