Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 May 2020 05:41:02 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r360684 - stable/11/sys/dev/ata/chipsets
Message-ID:  <202005060541.0465f2WP012491@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Wed May  6 05:41:02 2020
New Revision: 360684
URL: https://svnweb.freebsd.org/changeset/base/360684

Log:
  MFC r335894 (by sbruno):
  
  Reset indentation of this flag. No functional change intended.
  Found with gcc.
  
  sys/dev/ata/chipsets/ata-siliconimage.c: In function 'ata_cmd_ch_attach':
  sys/dev/ata/chipsets/ata-siliconimage.c:187:5:
   warning: this 'if' clause does not guard... [-Wmisleading-indentation]
       if (ctlr->chip->cfg2 & SII_INTR)
       ^~
  sys/dev/ata/chipsets/ata-siliconimage.c:190:2:
  note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    ch->flags |= ATA_NO_ATAPI_DMA;

Modified:
  stable/11/sys/dev/ata/chipsets/ata-siliconimage.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/ata/chipsets/ata-siliconimage.c
==============================================================================
--- stable/11/sys/dev/ata/chipsets/ata-siliconimage.c	Wed May  6 05:35:00 2020	(r360683)
+++ stable/11/sys/dev/ata/chipsets/ata-siliconimage.c	Wed May  6 05:41:02 2020	(r360684)
@@ -185,7 +185,7 @@ ata_cmd_ch_attach(device_t dev)
     if (ctlr->chip->cfg2 & SII_INTR)
 	ch->hw.status = ata_cmd_status;
 
-	ch->flags |= ATA_NO_ATAPI_DMA;
+    ch->flags |= ATA_NO_ATAPI_DMA;
 
     return 0;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005060541.0465f2WP012491>