Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Dec 2015 16:31:28 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r292877 - head/bin/pax
Message-ID:  <201512291631.tBTGVS6F093454@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Tue Dec 29 16:31:28 2015
New Revision: 292877
URL: https://svnweb.freebsd.org/changeset/base/292877

Log:
  pax: prevent possible buffer overflow
  
  Or at least quiet down some static analyzers about it.
  
  CID:	978835
  MFC after:	1 week
  Obtained from:	OpenBSD

Modified:
  head/bin/pax/pat_rep.c

Modified: head/bin/pax/pat_rep.c
==============================================================================
--- head/bin/pax/pat_rep.c	Tue Dec 29 16:29:42 2015	(r292876)
+++ head/bin/pax/pat_rep.c	Tue Dec 29 16:31:28 2015	(r292877)
@@ -878,7 +878,7 @@ rep_name(char *name, int *nlen, int prnt
 	 * (the user already saw that substitution go by)
 	 */
 	pt = rephead;
-	(void)strcpy(buf1, name);
+	(void)strlcpy(buf1, name, sizeof(buf1));
 	inpt = buf1;
 	outpt = nname;
 	endpt = outpt + PAXPATHLEN;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512291631.tBTGVS6F093454>