Date: Fri, 30 Nov 2007 16:20:57 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Peter Wemm <peter@FreeBSD.org> Subject: Re: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h Message-ID: <1196457657.1769.10.camel@shumai.marcuscom.com> In-Reply-To: <200711301248.37322.peter@wemm.org> References: <200711290634.lAT6YUpr004269@repoman.freebsd.org> <474EF1D5.7070103@FreeBSD.org> <200711301248.37322.peter@wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-rSn5ZHY9P7P8i1XHX+dw Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2007-11-30 at 12:48 -0800, Peter Wemm wrote: > On Thursday 29 November 2007, Joe Marcus Clarke wrote: > > Peter Wemm wrote: > > > peter 2007-11-29 06:34:30 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/compat/linprocfs linprocfs.c > > > sys/kern kern_clock.c > > > sys/sys pcpu.h resource.h > > > Log: > > > Move the shared cp_time array (counts %sys, %user, %idle etc) to > > > the per-cpu area. cp_time[] goes away and a new function creates a > > > merged cp_time-like array for things like linprocfs, sysctl etc.=20 > > > The atomic ops for updating cp_time[] in statclock go away, and the > > > scope of the thread lock is reduced. > > > > > > sysctl kern.cp_time returns a backwards compatible cp_time[] > > > array. A new kern.cp_times sysctl returns the individual per-cpu > > > stats. > > > > > > I have pending changes to make top and vmstat optionally show > > > per-cpu stats. > > > > > > I'm very aware that there are something like 5 or 6 other > > > versions "out there" for doing this - but none were handy when I > > > needed them. > > > > > > I did merge my changes with John Baldwin's, and ended up > > > replacing a few chunks of my stuff with his, and stealing some > > > other code. > > > > libgtop uses the cp_time interface. Can __FreeBSD_version be bumped > > for this? And thanks for doing this work. > > > > Joe >=20 > If it uses sysctl kern.cp_time, then there is no change required... >=20 > If you want to get the new per-cpu stats, then just test for the=20 > existence of kern.cp_times at runtime. There's no compile-time visible=20 > changes. But cpu_time from sys/resource.h did go away. As it turns out, I did convert libgtop to using sysctl instead of kvm a while ago, so this is moot. Joe >=20 --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-rSn5ZHY9P7P8i1XHX+dw Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHUH61b2iPiv4Uz4cRAt0nAKCsAeFmZYJwcfB+tWEHDWn3ANlf+ACfb/eM qjsbWAFsLGxD9bPeXhT37ZU= =U8mY -----END PGP SIGNATURE----- --=-rSn5ZHY9P7P8i1XHX+dw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1196457657.1769.10.camel>