Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Apr 2014 18:41:38 +0100
From:      Mark R V Murray <markm@FreeBSD.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r265045 - projects/random_number_generator/sys/dev/random
Message-ID:  <369E19F8-5694-4AF8-97EF-4F691FD52C5D@FreeBSD.org>
In-Reply-To: <2404556.5ed5qdM2Fl@ralph.baldwin.cx>
References:  <201404280751.s3S7p8Sg008554@svn.freebsd.org> <2404556.5ed5qdM2Fl@ralph.baldwin.cx>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]

On 28 Apr 2014, at 14:12, John Baldwin <jhb@freebsd.org> wrote:

> On Monday, April 28, 2014 07:51:08 AM Mark Murray wrote:
>> -#if !defined(__arm__) && !defined(__mips__) && !defined(__i386__) &&
>> !defined(__pc98__) +#if !defined(__arm__) && !defined(__mips__) &&
>> !defined(__i386__) && !defined(__pc98__) && !defined(__powerpc__) /* We do
>> have an inbuilt __uint128_t type */
> 
> A better test would be to use
> 
> #ifdef __SIZEOF_INT128__
> 
> instead of listing architectures.  (Especially given it might be true on
> a given platform based on compiler options like -march.)  This is what
> Boost uses to detect a native 128-bit integer and works with both GCC and
> clang.

Thank you!

This was on my “to-ask” list.

M
-- 
Mark R V Murray


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQCVAwUBU16S1t58vKOKE6LNAQrZSwP+IG8Riv12J3g7nHaYdqLEQvEv5Opx2Q4S
UoFXVM5Er4gafRo3MdcaCoKcp/HN2QINK68PCEGs3a7mbaeccRcsK/MC2sNb8IVV
Tu+rD0vbnu94Z+X5rs9Qs0bEPDUXvZAxGDGu+c7itOcgbbj+e8hwGQLS1xkCZl8M
BraWujIveg4=
=MXkW
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?369E19F8-5694-4AF8-97EF-4F691FD52C5D>