Date: Fri, 11 Mar 2022 15:30:54 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262038] fts(3): Check for readdir(3) errors Message-ID: <bug-262038-227-Y2z0KO2d8u@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-262038-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #11 from Mark Johnston <markj@FreeBSD.org> --- (In reply to Mahmoud Abumandour from comment #6) Sorry for the delayed reply. This mostly looks ok to me, but I have a few more nits: - Rather than setting errno = 0 in fts_safe_readdir(), I think it's better to set readdir_errno only when readdir(2) fails. - FreeBSD style (see the style(9) man page) is to put declarations at the beginning of the function, so fts_safe_readdir() should declare "ret" at the beginning. - The comment above the readdir_errno check does not seem to be needed. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262038-227-Y2z0KO2d8u>