Date: Wed, 9 Oct 2024 10:27:22 +0200 From: Paul Floyd <paulf2718@gmail.com> To: freebsd-current@freebsd.org Subject: Re: Problems with FreeBSD-15.0-CURRENT-amd64-20241003 Message-ID: <CALUVJ=AhS1NA_4JNEC-c2hMjBMHhNZh0VzLjdvCVDh5siDrriw@mail.gmail.com> In-Reply-To: <ZwYrWwd5XU_TRbEw@kib.kiev.ua> References: <7bdb3c71-8a36-444e-8b1d-9c4f789fe638@gmail.com> <ZwYrWwd5XU_TRbEw@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > > On Wed, 9 Oct 2024 at 09:08, Konstantin Belousov <kostikbel@gmail.com> > wrote: > On Wed, Oct 09, 2024 at 06:35:08AM +0000, Paul Floyd wrote: > > The biggest problem is with Helgrind. All apps now generate an extra > error > > > > ==68593== Thread #1: Exiting thread still holds 1 lock > > ==68593== at 0x4BBB5DA: _exit (in /lib/libsys.so.7) > > ==68593== by 0x49FC1C0: exit (in /lib/libc.so.7) > > ==68593== by 0x491CA10: __libc_start1 (in /lib/libc.so.7) > > ==68593== by 0x20182F: (below main) (crt1_s.S:83) > > This is intended, see 3f3ec4b99f79d32a0bf15495559ca9883bd751f2. > > Reply to list is better, Ug. I need to test but I don't think that I can simply add a default suppression for this as that would also mask any leaked user locks. I can probably check whether it's the main thread (I assume that this code doesn't run on subsidiary threads) and then only warn if there are 2 or more locks held. The next problem is that I don't see any way to tell whether I need to allow one lock or not. This is all userland so so __FreeBSD_version change. Also I don't see any public symbols. That just leaves me with configure time 'uname' checks. A+ Paul [-- Attachment #2 --] <div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="color:rgb(80,0,80)">On Wed, 9 Oct 2024 at 09:08, Konstantin Belousov <</span><a href="mailto:kostikbel@gmail.com" target="_blank">kostikbel@gmail.com</a><span style="color:rgb(80,0,80)">> wrote:</span><br></blockquote><div class="gmail_quote"><span class="gmail-im" style="color:rgb(80,0,80)"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Oct 09, 2024 at 06:35:08AM +0000, Paul Floyd wrote:<br>> The biggest problem is with Helgrind. All apps now generate an extra error<br>><br>> ==68593== Thread #1: Exiting thread still holds 1 lock<br>> ==68593== at 0x4BBB5DA: _exit (in /lib/libsys.so.7)<br>> ==68593== by 0x49FC1C0: exit (in /lib/libc.so.7)<br>> ==68593== by 0x491CA10: __libc_start1 (in /lib/libc.so.7)<br>> ==68593== by 0x20182F: (below main) (crt1_s.S:83)<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is intended, see 3f3ec4b99f79d32a0bf15495559ca9883bd751f2.<br><br></blockquote><div><br></div><div>Reply to list is better,</div><div><br></div></span><div>Ug. I need to test but I don't think that I can simply add a default suppression for this as that would also mask any leaked user locks.</div><div><br></div><div>I can probably check whether it's the main thread (I assume that this code doesn't run on subsidiary threads) and then only warn if there are 2 or more locks held. The next problem is that I don't see any way to tell whether I need to allow one lock or not. This is all userland so so __FreeBSD_version change. Also I don't see any public symbols. That just leaves me with configure time 'uname' checks.</div><div><br></div><div>A+</div></div><div><span style="color:rgb(136,136,136)">Paul</span> </div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALUVJ=AhS1NA_4JNEC-c2hMjBMHhNZh0VzLjdvCVDh5siDrriw>