Date: Thu, 26 Jul 2018 07:22:30 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Daichi GOTO <daichi@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336737 - head/usr.bin/top Message-ID: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201807261353.w6QDrMRI036171@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: daichi > Date: Thu Jul 26 13:53:22 2018 > New Revision: 336737 > URL: https://svnweb.freebsd.org/changeset/base/336737 > > Log: > top(1): forgot in r336160 It is helpful to say what was forgot in the commit message as when you are reading a svn log output you do not have the diff to show you what it was that has been forgot. Better message would of been: Remove utf8strvisx prototype, forgotten in r336160 Thanks, Rod > > Approved by: gnn (mentor) > Differential Revision: https://reviews.freebsd.org/D16452 > > Modified: > head/usr.bin/top/utils.h > > Modified: head/usr.bin/top/utils.h > ============================================================================== > --- head/usr.bin/top/utils.h Thu Jul 26 13:33:10 2018 (r336736) > +++ head/usr.bin/top/utils.h Thu Jul 26 13:53:22 2018 (r336737) > @@ -22,5 +22,4 @@ const char *format_time(long); > char *format_k(int64_t); > int string_index(const char *string, const char * const *array); > int find_pid(pid_t pid); > -int utf8strvisx(char *, const char *, size_t); > > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807261422.w6QEMUwH046070>