Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Jul 2023 18:35:10 GMT
From:      Doug Moore <dougm@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6419ed7ee7d0 - main - inline_fls: drop compile-time check
Message-ID:  <202307061835.366IZAg8097383@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by dougm:

URL: https://cgit.FreeBSD.org/src/commit/?id=6419ed7ee7d0580b061b5913b05695ccd47fe81e

commit 6419ed7ee7d0580b061b5913b05695ccd47fe81e
Author:     Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2023-07-06 18:32:59 +0000
Commit:     Doug Moore <dougm@FreeBSD.org>
CommitDate: 2023-07-06 18:32:59 +0000

    inline_fls: drop compile-time check
    
    HAVE_INLINE_FLSLL is #defined always. This change assumes that where
    __HAVE_INLINE_FLSLL is tested, the two leading underscores are a
    mistake, and that the code will be better for using the efficient
    flsll implementation.
    Reviewed by:    markj, mhorne
    Differential Revision:  https://reviews.freebsd.org/D40705
---
 sys/kern/kern_resource.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sys/kern/kern_resource.c b/sys/kern/kern_resource.c
index b1ce9526d4cc..b030c0552cc9 100644
--- a/sys/kern/kern_resource.c
+++ b/sys/kern/kern_resource.c
@@ -885,11 +885,6 @@ rufetchtd(struct thread *td, struct rusage *ru)
 	calcru1(p, &td->td_rux, &ru->ru_utime, &ru->ru_stime);
 }
 
-/* XXX: the MI version is too slow to use: */
-#ifndef __HAVE_INLINE_FLSLL
-#define	flsll(x)	(fls((x) >> 32) != 0 ? fls((x) >> 32) + 32 : fls(x))
-#endif
-
 static uint64_t
 mul64_by_fraction(uint64_t a, uint64_t b, uint64_t c)
 {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307061835.366IZAg8097383>