Date: Tue, 30 Nov 2004 22:36:43 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8 Message-ID: <20041130203643.GB20833@ip.net.ua> In-Reply-To: <54142.1101843659@critter.freebsd.dk> References: <20041130192316.GB3845@ip.net.ua> <54142.1101843659@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Nov 30, 2004 at 08:40:59PM +0100, Poul-Henning Kamp wrote: > In message <20041130192316.GB3845@ip.net.ua>, Ruslan Ermilov writes: > > >> The reason I did not remove MNT_NODEV but only #defined it to zero was > >> to make it silently ignored. > >> > >To make it silently ignored, you should have left it with its old value. > >Most operations with MNT_* constants are "bitwise AND", and so zero was > >not a good choice. > > I tried to find my copy of "Bitmaps for dummies" to check what > you're saying but I can't find it right now, still, I'm very sure > that you are wrong, I just don't have the book to prove it. > > Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK. > Well, definitely *not* in sbin/mount/mount.c. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBrNnbqRfpzJluFF4RAoebAJ9VxWIh89i+MguDFxVxXec4UcWsiwCfRiHW qWzXVLtJq7ULu8fnUQ+zalc= =PDuS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041130203643.GB20833>