Date: Thu, 13 Mar 2025 10:51:41 +0000 From: Jamie Landeg-Jones <jamie@catflap.org> To: kevans@FreeBSD.org, jamie@catflap.org, freebsd-current@FreeBSD.org Subject: Re: grep(1) bug - duplicate output lines Message-ID: <202503131051.52DApfMi079466@donotpassgo.dyslexicfish.net> In-Reply-To: <4e719f32-7be0-46dd-8113-d8bee17a846e@FreeBSD.org> References: <202309280240.38S2esgN015958@donotpassgo.dyslexicfish.net> <8d0658e9-8984-a241-ad1d-e5aa1328d7fa@FreeBSD.org> <202309291629.38TGTU56092229@donotpassgo.dyslexicfish.net> <202309291825.38TIPNN2096338@donotpassgo.dyslexicfish.net> <85039cfe-3c59-173d-f2f2-f0ca8e0fa1c8@FreeBSD.org> <883774ff-c630-72bf-ebc3-cc53e4d40d03@FreeBSD.org> <202503120021.52C0LG7D088609@donotpassgo.dyslexicfish.net> <503a0ad0-7a03-4979-9faf-d220f7b3c3a5@FreeBSD.org> <4e719f32-7be0-46dd-8113-d8bee17a846e@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Kyle Evans <kevans@FreeBSD.org> wrote: > > Which would have revealed: > > > > Standard output: > > Executing command [ zgrep -e test ] > > > > Standard error: > > Fail: incorrect exit status: 134, expected: 0 > > stdout: > > > > stderr: > > Assertion failed: (pc->matchidx > 0), function procmatch_match, file / > > usr/src/usr.bin/grep/util.c, line 223. > > Abort trap (core dumped) > > -- > > > > I'll take a little bit to understand the patch I wrote back then, add an > > extra test to cover the originally-reported bug, fix the patch, then get > > it into Phabricator ASAP. Sorry for dropping this- > > > > Thanks, > > > > Kyle Evans > > > > Here we go: https://reviews.freebsd.org/D49324 Wow, that was quick! Cheers! Yes, despite my best efforts :-), it works perfectly for me (14-stable) Anyway, not only should I have run the tests, I totally forgot about the original issue too - your patch was in my local patch tree, which is distributed to all my hosts, so I forgot the patch hadn't been commited - so much so, when I stumbled upon the current assert issue, I was initially puzzled where the difference between my copy of util.c and the one in current came from! Thanks for your help! Jamiehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503131051.52DApfMi079466>