Date: Tue, 20 Nov 2012 23:00:30 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/173744: [PATCH] rtsold usage message contains non-sensical -a option in interface required mode usage Message-ID: <201211202300.qAKN0UvP011512@red.freebsd.org> Resent-Message-ID: <201211202310.qAKNA0M8036886@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173744
>Category: bin
>Synopsis: [PATCH] rtsold usage message contains non-sensical -a option in interface required mode usage
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 20 23:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Garrett Cooper
>Release: 10-CURRENT
>Organization:
EMC Isilon
>Environment:
FreeBSD forza.west.isilon.com 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #2 r243289: Mon Nov 19 13:30:09 PST 2012 root@forza.west.isilon.com:/usr/obj/usr/src/sys/FORZA amd64
>Description:
-a should be omitted from the mode when one or more interfaces are specified...
$ rtsold --help
rtsold: illegal option -- -
usage: rtsold [-adDfFm1] [-O script-name] [-P pidfile] [-R script-name] interfaces... <-- WRONG
usage: rtsold [-dDfFm1] [-O script-name] [-P pidfile] [-R script-name] -a
.. like noted in the manpage...
RTSOLD(8) FreeBSD System Manager's Manual RTSOLD(8)
NAME
rtsold, rtsol -- router solicitation daemon
SYNOPSIS
rtsold [-dDfFmu1] [-O script-name] [-p pidfile] [-R script-name] <-- CORRECT
interface ...
rtsold [-dDfFmu1] [-O script-name] [-p pidfile] [-R script-name] -a
rtsol [-dDu] [-O script-name] [-R script-name] interface ...
rtsol [-dDu] [-O script-name] [-R script-name] -a
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: usr.sbin/rtsold/rtsold.c
===================================================================
--- usr.sbin/rtsold/rtsold.c (revision 243323)
+++ usr.sbin/rtsold/rtsold.c (working copy)
@@ -839,7 +839,7 @@
usage(void)
{
#ifndef SMALL
- fprintf(stderr, "usage: rtsold [-adDfFm1] [-O script-name] "
+ fprintf(stderr, "usage: rtsold [-dDfFm1] [-O script-name] "
"[-P pidfile] [-R script-name] interfaces...\n");
fprintf(stderr, "usage: rtsold [-dDfFm1] [-O script-name] "
"[-P pidfile] [-R script-name] -a\n");
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211202300.qAKN0UvP011512>