Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 2 Oct 2019 11:01:05 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r352994 - head/sys/dev/mlx5/mlx5_core
Message-ID:  <201910021101.x92B15KE059577@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: hselasky
Date: Wed Oct  2 11:01:05 2019
New Revision: 352994
URL: https://svnweb.freebsd.org/changeset/base/352994

Log:
  Improve mlx5_fwdump_prep logging in mlx5core.
  
  Submitted by:	slavash@
  MFC after:	3 days
  Sponsored by:	Mellanox Technologies

Modified:
  head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c

Modified: head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c	Wed Oct  2 10:59:44 2019	(r352993)
+++ head/sys/dev/mlx5/mlx5_core/mlx5_fwdump.c	Wed Oct  2 11:01:05 2019	(r352994)
@@ -72,7 +72,8 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
 	if (error != 0) {
 		/* Inability to create a firmware dump is not fatal. */
 		mlx5_core_warn(mdev,
-		    "mlx5_fwdump_prep failed %d\n", error);
+		    "Failed to find vendor-specific capability, error %d\n",
+		    error);
 		return;
 	}
 	error = mlx5_vsc_lock(mdev);
@@ -86,7 +87,7 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
 	dev = mdev->pdev->dev.bsddev;
 	vsc_addr = mdev->vsc_addr;
 	if (vsc_addr == 0) {
-		mlx5_core_warn(mdev, "Cannot read vsc, no address\n");
+		mlx5_core_warn(mdev, "Cannot read VSC, no address\n");
 		goto unlock_vsc;
 	}
 
@@ -97,7 +98,8 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
 		error = mlx5_vsc_wait_on_flag(mdev, 1);
 		if (error != 0) {
 			mlx5_core_warn(mdev,
-		    "Failed waiting for read complete flag, error %d\n", error);
+		    "Failed waiting for read complete flag, error %d addr %#x\n",
+			    error, addr);
 			goto unlock_vsc;
 		}
 		pci_read_config(dev, vsc_addr + MLX5_VSC_DATA_OFFSET, 4);
@@ -120,7 +122,8 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
 		error = mlx5_vsc_wait_on_flag(mdev, 1);
 		if (error != 0) {
 			mlx5_core_warn(mdev,
-		    "Failed waiting for read complete flag, error %d\n", error);
+		    "Failed waiting for read complete flag, error %d addr %#x\n",
+			    error, addr);
 			free(mdev->dump_rege, M_MLX5_DUMP);
 			mdev->dump_rege = NULL;
 			goto unlock_vsc;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910021101.x92B15KE059577>