Date: Wed, 31 Jan 2018 13:49:25 -0800 From: John Baldwin <jhb@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328637 - head/lib/libgcc_s Message-ID: <2842708.9sbgdJgr1q@ralph.baldwin.cx> In-Reply-To: <201801312141.w0VLfgkw051167@repo.freebsd.org> References: <201801312141.w0VLfgkw051167@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 31, 2018 09:41:42 PM Glen Barber wrote: > Author: gjb > Date: Wed Jan 31 21:41:42 2018 > New Revision: 328637 > URL: https://svnweb.freebsd.org/changeset/base/328637 > > Log: > Fix build by escaping a line break. > > PR: 225597 > Submitted by: cbnfinley at gmail.com > Sponsored by: The FreeBSD Foundation > > Modified: > head/lib/libgcc_s/Makefile > > Modified: head/lib/libgcc_s/Makefile > ============================================================================== > --- head/lib/libgcc_s/Makefile Wed Jan 31 21:14:59 2018 (r328636) > +++ head/lib/libgcc_s/Makefile Wed Jan 31 21:41:42 2018 (r328637) > @@ -35,7 +35,7 @@ SRCS+= s_scalbnf.c > > # Don't include long double routines on architectures where long double > # is the same size as double. > -.if ${MACHINE_CPUARCH} != "mips" && ${MACHINE_CPUARCH} != "arm" && > +.if ${MACHINE_CPUARCH} != "mips" && ${MACHINE_CPUARCH} != "arm" && \ > ${MACHINE_CPUARCH} != "powerpc" > SRCS+= s_fmaxl.c > SRCS+= s_logbl.c Thanks. I've been building MIPS worlds with this change for months. I've no idea why bmake would work for that case but fail for others. You'd think if it was a syntax error it would fail reliably? Perhaps it is doing short-circuit eval such that it didn't parse the rest of the line? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2842708.9sbgdJgr1q>