Date: Tue, 21 Jan 2003 16:23:40 -0800 From: Alfred Perlstein <bright@mu.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: sam@errno.com, arch@FreeBSD.ORG Subject: Re: Alfre's malloc changes: the next step Message-ID: <20030122002340.GK42333@elvis.mu.org> In-Reply-To: <20030121.165125.29485504.imp@bsdimp.com> References: <20030121.144243.52206100.imp@bsdimp.com> <20030121233932.GI42333@elvis.mu.org> <072d01c2c1a7$0fbba490$52557f42@errno.com> <20030121.165125.29485504.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* M. Warner Losh <imp@bsdimp.com> [030121 15:53] wrote: > In message: <072d01c2c1a7$0fbba490$52557f42@errno.com> > "Sam Leffler" <sam@errno.com> writes: > : > Yes. Leave it alone, people may be shocked, but it's the right thing. > : > : You cannot commit stuff like this w/o calling for a review. > > Based on the feedback I've gotten so far, it looks like there's > widespread support for the backout + direction change. The reason > there's support is that it has been thought out and is bulletproof, > not a one-off hack. We've got to start using interfaces that are more > robust if we are to get the smp/kse work done. While your changes are > well intentioned, they take us away from a robust interface to a > hackish one that is sufficeint, but unverifiable. It's obivous that you either haven't even read or are too overwhelmed by whining to considered my points. I expect you to at least feign enough respect for me to consider the points I brought up in response to your post. The old interface was a hack to "remind" people too stupid to RTFM/UTSL about how the allocators worked. And they didn't work, there were still mistakes. This "hack" makes it _impossible_ to make any of the mistakes done previously. Your "fix" makes the same mistakes possible, but now will panic()s instead of doing what was intended if not written. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030122002340.GK42333>