Date: Wed, 28 Aug 2013 12:31:35 +0200 From: Ivan Voras <ivoras@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254986 - head/sys/ufs/ufs Message-ID: <CAF-QHFU-cdd2b-7PHwFW8H2Unmtpp4iid3bZwmqfwKVk3cR=-g@mail.gmail.com> In-Reply-To: <CACYV=-GtV5vwsd5zWX6=i-z2yHND8rZT_dWXhdjnBhMb4jjTvw@mail.gmail.com> References: <201308281006.r7SA6KSq010737@svn.freebsd.org> <CACYV=-GtV5vwsd5zWX6=i-z2yHND8rZT_dWXhdjnBhMb4jjTvw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 August 2013 12:25, Davide Italiano <davide@freebsd.org> wrote: > do you have any evidence that this change impacts positively (or > negatively) performances for some workloads? If yes, can you share? Yes, observation of my own servers. Without this, dirhash is basically useless since in certain situations everything gets evicted after 5 seconds and it never grows to its full potential. > Also, why did you choose the '60' value (rather than something else)? Personal experience. > I don't see any 'Reviewed by:' line in your commit message neither I > remember a public discussion on -current or -arch or -fs about this. > OTOH I think such changes deserve a wider discussion. See discussion in @stable.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF-QHFU-cdd2b-7PHwFW8H2Unmtpp4iid3bZwmqfwKVk3cR=-g>