Date: Thu, 19 Oct 2023 15:41:43 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Kristof Provost <kp@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h Message-ID: <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> In-Reply-To: <202310191420.39JEKitw071108@gitrepo.freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 Oct 2023, at 15:20, Kristof Provost <kp@FreeBSD.org> wrote: >=20 > The branch main has been updated by kp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc6cd830b0bc6= b815e8c4 >=20 > commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 > Author: Kristof Provost <kp@FreeBSD.org> > AuthorDate: 2023-10-19 10:06:29 +0000 > Commit: Kristof Provost <kp@FreeBSD.org> > CommitDate: 2023-10-19 14:19:39 +0000 >=20 > pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >=20 > When userspace includes pfvar.h it doesn't get the kernel's = COMPAT_* > defines, so we end up not having required symbols in userspace. = This > caused the libpfctl port to fail to build. >=20 > libpfctl will be updated to use the new netlink-based state export = code > soon, which will also fix thix build issue. >=20 > Sponsored by: Rubicon Communications, LLC ("Netgate") That=E2=80=99s normally a feature to stop userspace using deprecated = things. Will you be reverting this once libpfctl is fixed? One could also hack libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that=E2=80=99= s what was done for kbdcontrol to allow it to run on old kernels). Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1DDF7B7C-9137-48F4-80C9-FDCC82F47118>